Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: ui/views/controls/textfield/textfield.cc

Issue 1986153005: The on screen keyboard on Windows 8+ should not obscure the input field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address sky unittest review comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/win/osk_display_observer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/textfield/textfield.cc
diff --git a/ui/views/controls/textfield/textfield.cc b/ui/views/controls/textfield/textfield.cc
index dc0a9f2535810941f1720d9e131d0061120ed26d..0de58f5f976c5574e6cecf19a52d6f2d69d247b1 100644
--- a/ui/views/controls/textfield/textfield.cc
+++ b/ui/views/controls/textfield/textfield.cc
@@ -46,6 +46,7 @@
#if defined(OS_WIN)
#include "base/win/win_util.h"
+#include "ui/base/win/osk_display_manager.h"
#endif
#if defined(OS_LINUX) && !defined(OS_CHROMEOS)
@@ -768,8 +769,11 @@ void Textfield::OnGestureEvent(ui::GestureEvent* event) {
}
CreateTouchSelectionControllerAndNotifyIt();
#if defined(OS_WIN)
- if (!read_only())
- base::win::DisplayVirtualKeyboard();
+ if (!read_only()) {
+ DCHECK(ui::OnScreenKeyboardDisplayManager::GetInstance());
+ ui::OnScreenKeyboardDisplayManager::GetInstance()
+ ->DisplayVirtualKeyboard(nullptr);
+ }
#endif
event->SetHandled();
break;
« no previous file with comments | « ui/base/win/osk_display_observer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698