Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.h

Issue 1986153005: The on screen keyboard on Windows 8+ should not obscure the input field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address sky unittest review comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura.h
diff --git a/content/browser/renderer_host/render_widget_host_view_aura.h b/content/browser/renderer_host/render_widget_host_view_aura.h
index 51942cd96d961b17e3b8be7071351206533562de..a08bead112bb43e4a0b92e44f7bc996c5f8cb061 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura.h
+++ b/content/browser/renderer_host/render_widget_host_view_aura.h
@@ -59,6 +59,7 @@ class DelegatedFrameData;
namespace gfx {
class Canvas;
class Display;
+class Point;
class Rect;
}
@@ -70,6 +71,9 @@ namespace ui {
class CompositorLock;
class InputMethod;
class LocatedEvent;
+#if defined(OS_WIN)
+class OnScreenKeyboardObserver;
+#endif
class Texture;
class TouchSelectionController;
}
@@ -126,6 +130,8 @@ class CONTENT_EXPORT RenderWidgetHostViewAura
void SetBackgroundColor(SkColor color) override;
gfx::Size GetVisibleViewportSize() const override;
void SetInsets(const gfx::Insets& insets) override;
+ void FocusedNodeTouched(const gfx::Point& location_dips_screen,
+ bool editable) override;
// Overridden from RenderWidgetHostViewBase:
void InitAsPopup(RenderWidgetHostView* parent_host_view,
@@ -203,6 +209,7 @@ class CONTENT_EXPORT RenderWidgetHostViewAura
void TransformPointToLocalCoordSpace(const gfx::Point& point,
cc::SurfaceId original_surface,
gfx::Point* transformed_point) override;
+ void FocusedNodeChanged(bool is_editable_node) override;
// Overridden from ui::TextInputClient:
void SetCompositionText(const ui::CompositionText& composition) override;
@@ -638,6 +645,11 @@ class CONTENT_EXPORT RenderWidgetHostViewAura
// Contains a copy of the last context menu request parameters. Only set when
// we receive a request to show the context menu on a long press.
std::unique_ptr<ContextMenuParams> last_context_menu_params_;
+
+ // Set to true if we requested the on screen keyboard to be displayed.
+ bool virtual_keyboard_requested_;
+
+ std::unique_ptr<ui::OnScreenKeyboardObserver> keyboard_observer_;
#endif
bool has_snapped_to_boundary_;
« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.cc ('k') | content/browser/renderer_host/render_widget_host_view_aura.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698