content/browser/renderer_host/render_view_host_impl.h - Issue 1986153005: The on screen keyboard on Windows 8+ should not obscure the input field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_impl.h

Issue 1986153005: The on screen keyboard on Windows 8+ should not obscure the input field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address grt review comments and add unittest Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/renderer_host/render_view_host_impl.h

diff --git a/content/browser/renderer_host/render_view_host_impl.h b/content/browser/renderer_host/render_view_host_impl.h

index d54b2d7d57322c2ff413483ae9fe0fb8ae766c1d..174d0ad7731cc356ae3502546a5025395062ef24 100644

--- a/content/browser/renderer_host/render_view_host_impl.h

+++ b/content/browser/renderer_host/render_view_host_impl.h

@@ -393,9 +393,6 @@ class CONTENT_EXPORT RenderViewHostImpl : public RenderViewHost,

// The termination status of the last render view that terminated.

base::TerminationStatus render_view_termination_status_;

- // Set to true if we requested the on screen keyboard to be displayed.

- bool virtual_keyboard_requested_;

// True if the current focused element is editable.

bool is_focused_element_editable_;

« no previous file with comments | « base/win/win_util.cc ('k') | content/browser/renderer_host/render_view_host_impl.cc » ('j') | ui/base/win/osk_display_manager.cc » ('J')