content/browser/renderer_host/render_widget_host_view_base.h - Issue 1986153005: The on screen keyboard on Windows 8+ should not obscure the input field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_base.h

Issue 1986153005: The on screen keyboard on Windows 8+ should not obscure the input field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a check for viewport bottom bigger than view height Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_widget_host_view_aura.cc ('K') | « content/browser/renderer_host/render_widget_host_view_aura.cc ('k') | content/browser/renderer_host/render_widget_host_view_base.cc » ('j') | ui/base/win/osk_display_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_base.h

diff --git a/content/browser/renderer_host/render_widget_host_view_base.h b/content/browser/renderer_host/render_widget_host_view_base.h

index 8eb96897ecc8dc2feca83d74474372a6cdcf1550..16a04cc41c0827c5b2bf90d2d5e6d14a4256bc4c 100644

--- a/content/browser/renderer_host/render_widget_host_view_base.h

+++ b/content/browser/renderer_host/render_widget_host_view_base.h

@@ -97,6 +97,8 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,

void BeginFrameSubscription(

std::unique_ptr<RenderWidgetHostViewFrameSubscriber> subscriber) override;

void EndFrameSubscription() override;

+ void FocusedNodeTouched(const gfx::Point& location_dips_screen,

+ bool editable) override;

// This only needs to be overridden by RenderWidgetHostViewBase subclasses

// that handle content embedded within other RenderWidgetHostViews.