The on screen keyboard on Windows 8+ should not obscure the input field.

content/browser/renderer_host/render_view_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_view_host_impl.h"
 
 #include <set>
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 72 matching lines @@
 #include "ui/base/touch/touch_device.h"
 #include "ui/base/touch/touch_enabled.h"
 #include "ui/base/ui_base_switches.h"
 #include "ui/gfx/animation/animation.h"
 #include "ui/gfx/image/image_skia.h"
 #include "ui/gfx/native_widget_types.h"
 #include "ui/native_theme/native_theme_switches.h"
 #include "url/url_constants.h"
 
 #if defined(OS_WIN)
+#include "base/memory/singleton.h"
+#include "base/win/osk_display_manager.h"
 #include "base/win/win_util.h"
+#include "ui/aura/window.h"
 #include "ui/display/win/dpi.h"
 #include "ui/gfx/platform_font_win.h"
 #endif
 
 using base::TimeDelta;
 using blink::WebConsoleMessage;
 using blink::WebDragOperation;
 using blink::WebDragOperationNone;
 using blink::WebDragOperationsMask;
 using blink::WebInputEvent;
@@ skipping 55 matching lines @@
       display::win::GetSystemMetricsInDIP(SM_CYHSCROLL);
   prefs->arrow_bitmap_height_vertical_scroll_bar_in_dips =
       display::win::GetSystemMetricsInDIP(SM_CYVSCROLL);
   prefs->arrow_bitmap_width_horizontal_scroll_bar_in_dips =
       display::win::GetSystemMetricsInDIP(SM_CXHSCROLL);
 }
 #endif
 
 }  // namespace
 
+#if defined(OS_WIN)

[ncarter (slow), 2016/05/18 20:09:11]

This is getting to be more OS_WIN code in this file than seems tolerable.

I wonder if the guts of on-screen keyboard handling would make more sense living
in RenderWidgetHostViewAura? RenderWidgetHostView is supposed to be our platform
abstraction here, and this is a platform behavior.

[ananta, 2016/05/19 01:57:12]

Moved this RenderWidgetHostViewAura.

This involved adding a virtual method FocusedNodeTouched() to the base
RenderWidgetHostView class and so on. 

The FocusedNodeTouched() and FocusedNodeChanged() methods are overridden by
RWHVA.

+// This class implements the base::win::OnScreenKeyboardObserver interface
+// which provides notifications about the on screen keyboard on Windows getting
+// displayed or hidden in response to taps on editable fields.
+class OnScreenKeyboardObserver : public base::win::OnScreenKeyboardObserver {
+ public:
+  OnScreenKeyboardObserver(RenderViewHostImpl* host)

[ncarter (slow), 2016/05/18 20:09:11]

explicit

[ananta, 2016/05/19 01:57:13]

Done.

+    : host_(host) {
+  }
+
+  // base::win::OnScreenKeyboardObserver overrides.
+  void OnKeyboardVisible(const RECT& keyboard_rect) override {
+    DCHECK(host_);
+    RenderWidgetHostImpl* widget_host = host_->GetWidget();
+    if (widget_host && widget_host->GetView()) {
+      // We use the cursor position to determine whether the tap occurred
+      // inside the bounds of the on screen keyboard.
+      POINT cursor_pos = {};
+      ::GetCursorPos(&cursor_pos);

[sky, 2016/05/18 19:54:51]

Is the cursor position always updated for touch? None-the-less it would be
better if you could make OnFocusedNodeTouched take the location so you don't
have to look it up.

[ananta, 2016/05/19 02:18:47]

It is updated for touch. I pass the cursor position to the newly added
FocusedNodeTouched function in RenderWidgetHostView.

+      if (::PtInRect(&keyboard_rect, cursor_pos)) {
+        DVLOG(1) << "OSK covering focus point.";
+        // We set the viewport to the bounds of the keyboard with an offset of
+        // 10 to ensure that the editable field gets scrolled into view
+        // correctly.
+        gfx::Rect display_rect(keyboard_rect);
+        display_rect.set_y(display_rect.y() - 10);
+        display_rect.set_height(display_rect.height() - 10);
+        widget_host->GetView()->SetInsets(
+            gfx::Insets(0, 0, display_rect.height(), 0));

[sky, 2016/05/18 19:54:52]

Shouldn't this depend upon the region of the renderer view that intersects the
keyboard?

[ananta, 2016/05/19 02:18:47]

Yeah. Updated. PTAL

+        widget_host->ScrollFocusedEditableNodeIntoRect(display_rect);
+      } else {
+        // Restore the viewport.
+        widget_host->GetView()->SetInsets(gfx::Insets());
+      }
+    }
+  }
+
+  void OnKeyboardHidden(const RECT& keyboard_rect) override {
+    DCHECK(host_);
+    RenderWidgetHost* widget_host = host_->GetWidget();
+    // Restore the viewport.
+    if (widget_host && widget_host->GetView()) {
+      widget_host->GetView()->SetInsets(gfx::Insets());

[sky, 2016/05/18 19:54:52]

Should this be done in the constructor too?

[ananta, 2016/05/19 01:57:12]

Done.

+    }
+  }
+
+ private:
+  RenderViewHostImpl* host_;
+};

[sky, 2016/05/18 19:54:51]

DISALLOW...

[ananta, 2016/05/19 01:57:13]

Done.

+#endif
+
 // static
 const int64_t RenderViewHostImpl::kUnloadTimeoutMS = 1000;
 
 ///////////////////////////////////////////////////////////////////////////////
 // RenderViewHost, public:
 
 // static
 RenderViewHost* RenderViewHost::FromID(int render_process_id,
                                        int render_view_id) {
   return RenderViewHostImpl::FromID(render_process_id, render_view_id);
@@ skipping 1113 matching lines @@
     bad_message::ReceivedBadMessage(GetProcess(),
                                     bad_message::RVH_FILE_CHOOSER_PATH);
     return;
   }
 
   delegate_->RunFileChooser(this, params);
 }
 
 void RenderViewHostImpl::OnFocusedNodeTouched(bool editable) {
 #if defined(OS_WIN)
+  base::win::OnScreenKeyboardDisplayManager* osk_display_manager =
+    base::win::OnScreenKeyboardDisplayManager::GetInstance();
+  DCHECK(osk_display_manager);
   if (editable) {
-    virtual_keyboard_requested_ = base::win::DisplayVirtualKeyboard();
+    keyboard_observer_.reset(new OnScreenKeyboardObserver(this));

[sky, 2016/05/18 19:54:51]

Is it possible the keyboard is already visible at the time you create
OnScreenKeyboardObserver? I'm wondering if it's constructor needs to check
visibility and do what OnKeyboardVisible does?

[ananta, 2016/05/19 01:57:13]

I don't think that would be needed. The DisplayVirtualKeyboard call below would
eventually run the task which would notify our observer about the keyboard
becoming visible.

+    virtual_keyboard_requested_ = osk_display_manager->DisplayVirtualKeyboard(
+        keyboard_observer_.get());
     delegate_->SetIsVirtualKeyboardRequested(true);
   } else {
     virtual_keyboard_requested_ = false;
     delegate_->SetIsVirtualKeyboardRequested(false);
-    base::win::DismissVirtualKeyboard();
+    osk_display_manager->DismissVirtualKeyboard(keyboard_observer_.get());

[ncarter (slow), 2016/05/18 20:09:11]

It's not clear to me why this DismissVirtualKeyboard event needs to pass
keyboard_observer_, but the void DismissVirtualKeyboardTask() {} function
doesn't. Is that inconsistent?

[ananta, 2016/05/19 01:57:12]

Yes. Removed the observer parameter.

   }
 #endif
 }
 
 bool RenderViewHostImpl::CanAccessFilesOfPageState(
     const PageState& state) const {
   ChildProcessSecurityPolicyImpl* policy =
       ChildProcessSecurityPolicyImpl::GetInstance();
 
   const std::vector<base::FilePath>& file_paths = state.GetReferencedFiles();
@@ skipping 29 matching lines @@
   } else {
     render_view_ready_on_process_launch_ = true;
   }
 }
 
 void RenderViewHostImpl::RenderViewReady() {
   delegate_->RenderViewReady(this);
 }
 
 }  // namespace content