Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1986153004: Skip the GL2ExtensionTests_egl_image_input_run test on all platforms. (Closed)

Created:
4 years, 7 months ago by Geoff Lang
Modified:
4 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Skip the GL2ExtensionTests_egl_image_input_run test on all platforms. The GLES2 conformance tests incorrectly detect that the GL_OES_EGL_image extension is available because it is a substring of the GL_OES_image_external extension. Since the command buffer service will never expose the EGL image extensions, skip this test on all platforms. BUG=612551 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/2151d0b3246856c17dd2e3a8ce6c33f083a57b7b Cr-Commit-Position: refs/heads/master@{#394398}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M gpu/gles2_conform_support/gles2_conform_test_expectations.txt View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Geoff Lang
PTAL: Encountered this issue when exposing GL_OES_image_external and GL_OES_image_external_essl3 in ANGLE.
4 years, 7 months ago (2016-05-17 19:41:12 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1986153004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1986153004/1
4 years, 7 months ago (2016-05-17 19:42:18 UTC) #6
piman
lgtm
4 years, 7 months ago (2016-05-17 19:47:36 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-17 21:28:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1986153004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1986153004/1
4 years, 7 months ago (2016-05-18 13:18:23 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 13:22:22 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 13:23:57 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2151d0b3246856c17dd2e3a8ce6c33f083a57b7b
Cr-Commit-Position: refs/heads/master@{#394398}

Powered by Google App Engine
This is Rietveld 408576698