Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 1986143002: Revert of Apply AllowCrossThreadAccess() in the callers of createCrossThreadTask() (Closed)

Created:
4 years, 7 months ago by Finnur
Modified:
4 years, 7 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-worker-reviews_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, falken, gavinp+loader_chromium.org, hongchan, horo+watch_chromium.org, Nate Chapin, kinuko+worker_chromium.org, loading-reviews_chromium.org, rwlbuis, Raymond Toy, sof, tommyw+watchlist_chromium.org, tyoshino+watch_chromium.org, yhirano+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@temp1549143002
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Apply AllowCrossThreadAccess() in the callers of createCrossThreadTask() (patchset #9 id:160001 of https://codereview.chromium.org/1766143002/ ) Reason for revert: Speculatively reverting this to see if it fixes a bunch of media tests on Windows that started failing as soon as this was checked in. Started here: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/5640 Original issue's description: > Apply AllowCrossThreadAccess() in the callers of createCrossThreadTask() > > This CL removes AllowCrossThreadAccess() calls in CrossThreadTask.h and applies > AllowCrossThreadAccess() at the callers of createCrossThreadAccess(). > > All previous uses of createCrossThreadTask() that would require > AllowCrossThreadAccess() are detected by compile errors > due to lack of CrossThreadCopier for WeakPtr/pointers because > https://codereview.chromium.org/1904283004/ removed CrossThreadCopier for > GCed pointers. > > BUG=597856 > > Committed: https://crrev.com/4c6e26cd4be4f511aa6a62e46c37178605fb3714 > Cr-Commit-Position: refs/heads/master@{#393573} TBR=tzik@chromium.org,haraken@chromium.org,kinuko@chromium.org,yutak@chromium.org,hiroshige@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=597856

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -60 lines) Patch
M third_party/WebKit/Source/core/dom/CrossThreadTask.h View 4 chunks +58 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/page/NetworkStateNotifier.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp View 2 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/CrossThreadHolder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrackSourcesRequestImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/Database.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (1 generated)
Finnur
Created Revert of Apply AllowCrossThreadAccess() in the callers of createCrossThreadTask()
4 years, 7 months ago (2016-05-17 12:24:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1986143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1986143002/1
4 years, 7 months ago (2016-05-17 12:24:49 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/6718) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 7 months ago (2016-05-17 12:26:26 UTC) #4
haraken
LGTM to revert
4 years, 7 months ago (2016-05-17 12:38:31 UTC) #5
hiroshige
On 2016/05/17 12:26:26, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 7 months ago (2016-05-17 12:40:30 UTC) #6
hiroshige
On 2016/05/17 12:40:30, hiroshige wrote: > On 2016/05/17 12:26:26, commit-bot: I haz the power wrote: ...
4 years, 7 months ago (2016-05-17 12:44:57 UTC) #7
Finnur
> According to > https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/5640, > the change lists contains some rebaselines for some (most?) ...
4 years, 7 months ago (2016-05-17 13:20:51 UTC) #8
hiroshige
4 years, 7 months ago (2016-05-17 13:54:49 UTC) #9
Message was sent while issue was closed.
On 2016/05/17 13:20:51, Finnur wrote:
> > According to
> >
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%...,
> > the change lists contains some rebaselines for some (most?) failed tests
(e.g.
> > r393582).
> > Perhaps rebaseline error?
> 
> Hmm, good catch. I missed that. I'll mark the tests instead.
> 
> > 
> > FYI at least the following CLs depends on this CL and thus should be
reverted
> > first.
> > https://codereview.chromium.org/1905343002/
> > https://codereview.chromium.org/1914453002/
> 
> I don't know. I don't have much of an appetite for multi-level speculative
> reverts (not even sure your CL is to blame). :)

Filed https://crbug.com/612442.

Powered by Google App Engine
This is Rietveld 408576698