Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-invalid-color-values.html

Issue 1986053004: Devtools Color: Basic support for #RRGGBBAA and #RGBA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-invalid-color-values.html
diff --git a/third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-invalid-color-values.html b/third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-invalid-color-values.html
index 6ad4d68951888e98d9765a11845c90201bc90548..7f139ce3b6be7f8d882762e64792fd018507bfb6 100644
--- a/third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-invalid-color-values.html
+++ b/third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-invalid-color-values.html
@@ -9,6 +9,9 @@ function test()
// Each of these is red. Some may need to be clipped to [0, 255].
'red',
'#F00',
+ '#F00F',
+ '#FF0000',
+ '#FF0000FF',
'rgb(255,0,0)',
'rgb(300,0,0)', // clipped to rgb(255,0,0)
'rgb(255,-10,0)', // clipped to rgb(255,0,0)
@@ -35,7 +38,6 @@ function test()
var invalidColors = [
// An invalid color, eg a value for a shorthand like 'border' which can have a color
'none',
- '#0000',
'#00000',
'#ggg',
'rgb(a,b,c)',
@@ -98,7 +100,7 @@ function test()
if (color.hasAlpha() && (colorFormat === cf.ShortHEX || colorFormat === cf.HEX))
continue;
// If there is no ShortHEX then skip it.
- if (colorFormat === cf.ShortHEX && !color.canBeShortHex())
+ if (colorFormat === cf.ShortHEX && color.detectHEXFormat() !== cf.ShortHEX)
continue;
// If there is no nickname, then skip it.
if (colorFormat === cf.Nickname && !color.nickname())

Powered by Google App Engine
This is Rietveld 408576698