third_party/WebKit/Source/devtools/front_end/ui/ColorSwatch.js - Issue 1986053004: Devtools Color: Basic support for #RRGGBBAA and #RGBA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/ColorSwatch.js

Issue 1986053004: Devtools Color: Basic support for #RRGGBBAA and #RGBA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/elements/Spectrum.js ('K') | « third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/ui/ColorSwatch.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui/ColorSwatch.js b/third_party/WebKit/Source/devtools/front_end/ui/ColorSwatch.js

index a9a6bf22679ab17c82bd9d0ddb6a35dbdf038c14..4178023f04a8d20dfe611936193c4e0162eeafbe 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui/ColorSwatch.js

+++ b/third_party/WebKit/Source/devtools/front_end/ui/ColorSwatch.js

@@ -136,7 +136,7 @@ WebInspector.ColorSwatch._nextColorFormat = function(color, curFormat)

if (color.nickname())

return cf.Nickname;

if (!color.hasAlpha())

dgozman 2016/05/20 00:55:15 I think this whole if should be just detectHEXForm

samli 2016/05/20 01:58:02 Done.

- return color.canBeShortHex() ? cf.ShortHEX : cf.HEX;

+ return color.detectHEXFormat() ? cf.ShortHEX : cf.HEX;

else

return cf.Original;

@@ -148,7 +148,7 @@ WebInspector.ColorSwatch._nextColorFormat = function(color, curFormat)

case cf.Nickname: