Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1986043002: Fix improper usage of SmiUntag operation in CodeStubAssembler. (Closed)

Created:
4 years, 7 months ago by Igor Sheludko
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix improper usage of SmiUntag operation in CodeStubAssembler. Committed: https://crrev.com/301da46750db7f41d7eba88c361a3a9b0ccbf903 Cr-Commit-Position: refs/heads/master@{#36270}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/code-stub-assembler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1986043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1986043002/1
4 years, 7 months ago (2016-05-17 06:48:52 UTC) #2
Igor Sheludko
PTAL
4 years, 7 months ago (2016-05-17 06:49:01 UTC) #4
Benedikt Meurer
LGTM.
4 years, 7 months ago (2016-05-17 06:52:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1986043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1986043002/1
4 years, 7 months ago (2016-05-17 06:57:33 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 07:30:05 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 07:31:55 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/301da46750db7f41d7eba88c361a3a9b0ccbf903
Cr-Commit-Position: refs/heads/master@{#36270}

Powered by Google App Engine
This is Rietveld 408576698