Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: chrome/browser/engagement/site_engagement_score.h

Issue 1986033002: Implement an observer interface for the site engagement service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@site-engagement-refactor
Patch Set: Convert to an observer interface Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/engagement/site_engagement_score.h
diff --git a/chrome/browser/engagement/site_engagement_score.h b/chrome/browser/engagement/site_engagement_score.h
index 7bebca721288261319567a1b77d8b93ecc64c414..a127cbd641dc31c8203d02a0549f231568b71032 100644
--- a/chrome/browser/engagement/site_engagement_score.h
+++ b/chrome/browser/engagement/site_engagement_score.h
@@ -30,6 +30,7 @@ class SiteEngagementScore {
// The number of points given for navigations.
NAVIGATION_POINTS,
+ POINTS_INCREMENT_FIRST = NAVIGATION_POINTS,
// The number of points given for user input.
USER_INPUT_POINTS,
@@ -39,6 +40,7 @@ class SiteEngagementScore {
// site to reach the daily engagement maximum.
VISIBLE_MEDIA_POINTS,
HIDDEN_MEDIA_POINTS,
+ POINTS_INCREMENT_LAST = HIDDEN_MEDIA_POINTS,
calamity 2016/05/24 08:09:32 This won't work if we add a new increment type to
dominickn 2016/05/25 07:21:32 Is there any reason to keep this enum append only?
calamity 2016/05/31 05:56:35 Guess not. This whole 3-way mapping is getting a b
// The number of points added to engagement when a site is launched from
// homescreen or added as a bookmark app. This bonus will apply for ten days
@@ -76,6 +78,7 @@ class SiteEngagementScore {
static double GetBootstrapPoints();
static double GetMediumEngagementBoundary();
static double GetHighEngagementBoundary();
+ static double GetMinimumEngagementIncrement();
// Update the default engagement settings via variations.
static void UpdateFromVariations(const char* param_name);

Powered by Google App Engine
This is Rietveld 408576698