chrome/browser/engagement/site_engagement_score.cc - Issue 1986033002: Implement an observer interface for the site engagement service.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/engagement/site_engagement_score.cc

Issue 1986033002: Implement an observer interface for the site engagement service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@site-engagement-refactor

Patch Set: Squash race condition in unit test which leads to a leak Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/engagement/site_engagement_score.h ('k') | chrome/browser/engagement/site_engagement_service.h » ('j') | chrome/browser/engagement/site_engagement_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/engagement/site_engagement_score.cc

diff --git a/chrome/browser/engagement/site_engagement_score.cc b/chrome/browser/engagement/site_engagement_score.cc

index 140cd01b1135e78e3b8eb5d14a60d6bff2f2cdfe..12efddd1008793f4612d064cc0273a7887c8ab74 100644

--- a/chrome/browser/engagement/site_engagement_score.cc

+++ b/chrome/browser/engagement/site_engagement_score.cc

@@ -119,6 +119,10 @@ double SiteEngagementScore::GetHighEngagementBoundary() {

return param_values[HIGH_ENGAGEMENT_BOUNDARY];

}

+double SiteEngagementScore::GetMinimumEngagementIncrement() {

+ return GetHiddenMediaPoints();

calamity 2016/05/19 03:28:22 This will limit the way we modify the experimental

dominickn 2016/05/19 04:36:14 Done.

// static

void SiteEngagementScore::UpdateFromVariations(const char* param_name) {

double param_vals[MAX_VARIATION];