chrome/chrome_browser.gypi - Issue 1986033002: Implement an observer interface for the site engagement service.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 1986033002: Implement an observer interface for the site engagement service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@site-engagement-refactor

Patch Set: Addressing reviewer comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index e6fb22c6902c73fcde99b662bbc752acb68fd058..980660a9744250a7d99828228c967ee2d927c6d6 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -1650,6 +1650,8 @@

'browser/engagement/site_engagement_helper.h',

'browser/engagement/site_engagement_metrics.cc',

'browser/engagement/site_engagement_metrics.h',

+ 'browser/engagement/site_engagement_observer.cc',

+ 'browser/engagement/site_engagement_observer.h',

'browser/engagement/site_engagement_score.cc',

'browser/engagement/site_engagement_score.h',

'browser/engagement/site_engagement_service.cc',

« no previous file with comments | « chrome/browser/engagement/site_engagement_service_unittest.cc ('k') | no next file » | no next file with comments »