Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 1985973004: add additional description of enum for TranslateBubbleUievent (Closed)

Created:
4 years, 7 months ago by ftang
Modified:
4 years, 7 months ago
Reviewers:
rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

add additional description of enum for TranslateBubbleUievent BUG=612558 Committed: https://crrev.com/a3ee02bc873cb815d4730786044209c4e15a73f4 Cr-Commit-Position: refs/heads/master@{#394256}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
ftang
Forget to add the description into the xml file last time. Notice I also made ...
4 years, 7 months ago (2016-05-17 19:54:15 UTC) #2
ftang
Forget to add the description into the xml file last time. Notice I also made ...
4 years, 7 months ago (2016-05-17 19:54:17 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1985973004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1985973004/1
4 years, 7 months ago (2016-05-17 19:58:17 UTC) #5
rkaplow
lgtm
4 years, 7 months ago (2016-05-17 21:44:03 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-17 22:12:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1985973004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1985973004/1
4 years, 7 months ago (2016-05-17 22:57:48 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 23:04:05 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 23:05:40 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a3ee02bc873cb815d4730786044209c4e15a73f4
Cr-Commit-Position: refs/heads/master@{#394256}

Powered by Google App Engine
This is Rietveld 408576698