Defer compositor context creation to the thread.

cc/output/renderer_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/output/delegating_renderer.h"
 #include "cc/output/gl_renderer.h"
 #include "cc/output/output_surface.h"
 #include "cc/test/fake_output_surface_client.h"
 #include "cc/test/fake_renderer_client.h"
 #include "cc/test/fake_resource_provider.h"
 #include "cc/test/test_context_provider.h"
 #include "cc/test/test_web_graphics_context_3d.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace cc {
 namespace {
 
 class TestOutputSurface : public OutputSurface {
  public:
-  explicit TestOutputSurface(scoped_refptr<ContextProvider> context_provider);
+  explicit TestOutputSurface(
+      std::unique_ptr<ContextProvider::DeferredCreate> context_provider_create);
   ~TestOutputSurface() override;
 
   // OutputSurface implementation
   void SwapBuffers(CompositorFrame* frame) override;
 };
 
 TestOutputSurface::TestOutputSurface(
-    scoped_refptr<ContextProvider> context_provider)
-    : OutputSurface(std::move(context_provider)) {}
+    std::unique_ptr<ContextProvider::DeferredCreate> context_provider_create)
+    : OutputSurface(std::move(context_provider_create)) {}
 
 TestOutputSurface::~TestOutputSurface() {
 }
 
 void TestOutputSurface::SwapBuffers(CompositorFrame* frame) {
   client_->DidSwapBuffers();
   client_->DidSwapBuffersComplete();
 }
 
 class MockContextProvider : public TestContextProvider {
  public:
-  explicit MockContextProvider(
-      std::unique_ptr<TestWebGraphicsContext3D> context)
-      : TestContextProvider(std::move(context)) {}
+  MockContextProvider()
+      : TestContextProvider(TestWebGraphicsContext3D::Create()) {}
+
+  class DeferredCreate : public ContextProvider::DeferredCreate {
+   public:
+    explicit DeferredCreate(MockContextProvider** created)
+        : created_(created) {}
+    scoped_refptr<ContextProvider> CreateContext() override {
+      scoped_refptr<MockContextProvider> context(new MockContextProvider);
+      *created_ = context.get();
+      return context;
+    }
+
+   private:
+    MockContextProvider** created_;
+  };
+
   MOCK_METHOD0(DeleteCachedResources, void());
 
  protected:
   ~MockContextProvider() {}
 };
 
 template <class T>
 std::unique_ptr<Renderer> CreateRenderer(RendererClient* client,
                                          const RendererSettings* settings,
                                          OutputSurface* output_surface,
@@ skipping 16 matching lines @@
     OutputSurface* output_surface,
     ResourceProvider* resource_provider) {
   return GLRenderer::Create(
       client, settings, output_surface, resource_provider, NULL, 0);
 }
 
 template <typename T>
 class RendererTest : public ::testing::Test {
  protected:
   virtual void SetUp() {
-    context_provider_ =
-        new MockContextProvider(TestWebGraphicsContext3D::Create());
-    output_surface_.reset(new TestOutputSurface(context_provider_));
+    output_surface_.reset(new TestOutputSurface(
+        base::MakeUnique<MockContextProvider::DeferredCreate>(
+            &context_provider_)));

[piman, 2016/05/17 03:41:40]

How about still creating the context provider here, pass it to the
MockContextProvider::DeferredCreate which just returns it directly in
CreateContext?

[danakj, 2016/05/17 19:53:33]

That is a pretty good idea. Done.

     output_surface_->BindToClient(&output_surface_client_);
     resource_provider_ =
         FakeResourceProvider::Create(output_surface_.get(), nullptr);
     renderer_ = CreateRenderer<T>(&renderer_client_,
                                   &tree_settings_,
                                   output_surface_.get(),
                                   resource_provider_.get());
   }
 
   FakeRendererClient renderer_client_;
   RendererSettings tree_settings_;
   FakeOutputSurfaceClient output_surface_client_;
-  scoped_refptr<MockContextProvider> context_provider_;
+  MockContextProvider* context_provider_;
   std::unique_ptr<OutputSurface> output_surface_;
   std::unique_ptr<ResourceProvider> resource_provider_;
   std::unique_ptr<Renderer> renderer_;
 };
 
 typedef ::testing::Types<DelegatingRenderer, GLRenderer> RendererTypes;
 TYPED_TEST_CASE(RendererTest, RendererTypes);
 
 TYPED_TEST(RendererTest, ContextPurgedWhenRendererBecomesInvisible) {
-  EXPECT_CALL(*(this->context_provider_.get()), DeleteCachedResources())
-      .Times(1);
+  EXPECT_CALL(*this->context_provider_, DeleteCachedResources()).Times(1);
 
   EXPECT_TRUE(this->renderer_->visible());
   this->renderer_->SetVisible(false);
   EXPECT_FALSE(this->renderer_->visible());
 }
 
 }  // namespace
 }  // namespace cc