chrome/browser/android/offline_pages/request_coordinator_factory.cc - Issue 1985923002: Wireframe scheduler implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/request_coordinator_factory.cc

Issue 1985923002: Wireframe scheduler implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More CR feedback per BauerB Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/background_scheduler_bridge.cc ('k') | components/offline_pages/background/request_coordinator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/request_coordinator_factory.cc

diff --git a/chrome/browser/android/offline_pages/request_coordinator_factory.cc b/chrome/browser/android/offline_pages/request_coordinator_factory.cc

index 4894de2d40ebf09dc8cce1632b51b7366375ccc1..c0ea51a0f9dbf2ae9aaffe586ff09c975da361eb 100644

--- a/chrome/browser/android/offline_pages/request_coordinator_factory.cc

+++ b/chrome/browser/android/offline_pages/request_coordinator_factory.cc

@@ -45,11 +45,8 @@ KeyedService* RequestCoordinatorFactory::BuildServiceInstanceFor(

std::unique_ptr<RequestQueueInMemoryStore> store(

new RequestQueueInMemoryStore());

std::unique_ptr<RequestQueue> queue(new RequestQueue(std::move(store)));

- // TODO(petewil) Add support for server based offliner when it is ready.

std::unique_ptr<Scheduler>

scheduler(new android::BackgroundSchedulerBridge());

- // TODO(petewil) Add support for server based offliner when it is ready.

return new RequestCoordinator(std::move(policy),

std::move(prerenderer_offliner),