Wireframe scheduler implementation

chrome/android/java/src/org/chromium/chrome/browser/ChromeBackgroundService.java

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeBackgroundService.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackgroundService.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackgroundService.java
index b8c90d046da508744946215b385b114b1593c845..533e65c54f3c25663de57998554405b6fef5b289 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackgroundService.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackgroundService.java
@@ -5,6 +5,7 @@
 package org.chromium.chrome.browser;
 
 import android.content.Context;
+import android.os.Bundle;
 
 import com.google.android.gms.gcm.GcmNetworkManager;
 import com.google.android.gms.gcm.GcmTaskService;
@@ -14,11 +15,11 @@ import org.chromium.base.Log;
 import org.chromium.base.ThreadUtils;
 import org.chromium.base.VisibleForTesting;
 import org.chromium.base.annotations.SuppressFBWarnings;
-import org.chromium.base.library_loader.LibraryLoader;
 import org.chromium.base.library_loader.ProcessInitException;
 import org.chromium.chrome.browser.init.ChromeBrowserInitializer;
 import org.chromium.chrome.browser.ntp.snippets.SnippetsBridge;
 import org.chromium.chrome.browser.ntp.snippets.SnippetsLauncher;
+import org.chromium.chrome.browser.offlinepages.BackgroundTask;
 import org.chromium.chrome.browser.offlinepages.OfflinePageUtils;
 import org.chromium.chrome.browser.precache.PrecacheController;
 
@@ -44,7 +45,7 @@ public class ChromeBackgroundService extends GcmTaskService {
                         break;
 
                     case OfflinePageUtils.TASK_TAG:
-                        handleOfflinePageBackgroundLoad(context);
+                        handleOfflinePageBackgroundLoad(context, params.getExtras());
                         break;
 
                     case SnippetsLauncher.TASK_TAG_WIFI_CHARGING:
@@ -124,12 +125,16 @@ public class ChromeBackgroundService extends GcmTaskService {
         PrecacheController.get(context).precache(tag);
     }
 
-    private void handleOfflinePageBackgroundLoad(Context context) {
-        // Gather UMA data to measure how often the user's machine is amenable to background
-        // loading when we wake to do a task.
-        if (LibraryLoader.isInitialized()) {
-            OfflinePageUtils.recordWakeupUMA(context);
+    private void handleOfflinePageBackgroundLoad(Context context, Bundle bundle) {
+        if (!hasPrecacheInstance()) {
+            launchBrowser(context);
         }
+
+        // Call BackgroundTask, provide context.
+        BackgroundTask task = new BackgroundTask();

[Bernhard Bauer, 2016/05/26 11:17:44]

It's a little bit unfortunate to use a class plainly named BackgroundTask here,
as  ChromeBackgroundService refers to doing arbitrary things in the background,
but BackgroundTask is just about offlining. Could we maybe rename that to
BackgroundOffliningTask?

[Pete Williamson, 2016/05/26 17:02:44]

Renamed to BackgroundOfflinerTask (we use Offliner in other places).

+        task.processBackgroundRequests(context, bundle);

[Bernhard Bauer, 2016/05/26 11:17:44]

You're not doing anything with |task| afterwards -- you could just make the
method static.

[Pete Williamson, 2016/05/26 17:02:44]

The method needs to be a class method, since it passes a this pointer to the
background scheduler bridge so the brige can get to a callback.

[Bernhard Bauer, 2016/05/27 12:36:15]

Yeah, but you could create an instance inside of the static method, and then
make the constructor private, to reduce the public API surface.

[Pete Williamson, 2016/05/27 17:57:58]

Done.

+        // TODO(petewil) if processBackgroundRequest returns false,return RESTART_RESCHEDULE
+        // to the GcmNetworkManager
     }
 
     @VisibleForTesting