Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3032)

Unified Diff: chrome/browser/android/offline_pages/request_coordinator_factory.cc

Issue 1985923002: Wireframe scheduler implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CR feedback per DewittJ and DougArnett Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/request_coordinator_factory.cc
diff --git a/chrome/browser/android/offline_pages/request_coordinator_factory.cc b/chrome/browser/android/offline_pages/request_coordinator_factory.cc
index 4894de2d40ebf09dc8cce1632b51b7366375ccc1..5cde4555ca9d2cd0083074cf07ea285215139d1c 100644
--- a/chrome/browser/android/offline_pages/request_coordinator_factory.cc
+++ b/chrome/browser/android/offline_pages/request_coordinator_factory.cc
@@ -42,14 +42,14 @@ KeyedService* RequestCoordinatorFactory::BuildServiceInstanceFor(
std::unique_ptr<OfflinerPolicy> policy(new OfflinerPolicy());
std::unique_ptr<OfflinerFactory> prerenderer_offliner(
new PrerenderingOfflinerFactory(context));
+ // TODO(petewil) Add support for server based offliner when it is ready.
dewittj 2016/05/24 16:56:19 I don't think this comment is really necessary her
Pete Williamson 2016/05/24 18:49:32 As I recall, I was asked to add it in a previous c
std::unique_ptr<RequestQueueInMemoryStore> store(
new RequestQueueInMemoryStore());
std::unique_ptr<RequestQueue> queue(new RequestQueue(std::move(store)));
- // TODO(petewil) Add support for server based offliner when it is ready.
-
+ // Create the Bridge from the C++ side (and it will initialize from the Java
dewittj 2016/05/24 16:56:19 I think this is out of date now.
Pete Williamson 2016/05/24 18:49:32 Done.
+ // side).
std::unique_ptr<Scheduler>
scheduler(new android::BackgroundSchedulerBridge());
- // TODO(petewil) Add support for server based offliner when it is ready.
return new RequestCoordinator(std::move(policy),
std::move(prerenderer_offliner),

Powered by Google App Engine
This is Rietveld 408576698