Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1985903003: gn/linux: Add missing tests to browser_tests. (Closed)

Created:
4 years, 7 months ago by Nico
Modified:
4 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn/linux: Add missing tests to browser_tests. BUG=604060 Committed: https://crrev.com/ef5de4c4c1074c888f423b1bd31ec9bb714ea8f0 Cr-Commit-Position: refs/heads/master@{#394146}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : . #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/test/BUILD.gn View 1 2 2 chunks +10 lines, -0 lines 3 comments Download

Messages

Total messages: 13 (3 generated)
Nico
4 years, 7 months ago (2016-05-17 00:23:50 UTC) #2
Dirk Pranke
https://codereview.chromium.org/1985903003/diff/20001/chrome/test/BUILD.gn File chrome/test/BUILD.gn (right): https://codereview.chromium.org/1985903003/diff/20001/chrome/test/BUILD.gn#newcode1027 chrome/test/BUILD.gn:1027: "../browser/ui/views/ime/input_ime_apitest_nonchromeos.cc", in gyp, it looks like input_ime_apitest_nonchromeos.cc is not ...
4 years, 7 months ago (2016-05-17 00:43:48 UTC) #3
Nico
https://codereview.chromium.org/1985903003/diff/20001/chrome/test/BUILD.gn File chrome/test/BUILD.gn (right): https://codereview.chromium.org/1985903003/diff/20001/chrome/test/BUILD.gn#newcode1027 chrome/test/BUILD.gn:1027: "../browser/ui/views/ime/input_ime_apitest_nonchromeos.cc", On 2016/05/17 00:43:48, Dirk Pranke wrote: > in ...
4 years, 7 months ago (2016-05-17 13:53:39 UTC) #4
Dirk Pranke
https://codereview.chromium.org/1985903003/diff/40001/chrome/test/BUILD.gn File chrome/test/BUILD.gn (right): https://codereview.chromium.org/1985903003/diff/40001/chrome/test/BUILD.gn#newcode1076 chrome/test/BUILD.gn:1076: } what happened to nacl_gdb_browsertest.cc?
4 years, 7 months ago (2016-05-17 16:33:06 UTC) #5
Nico
https://codereview.chromium.org/1985903003/diff/40001/chrome/test/BUILD.gn File chrome/test/BUILD.gn (right): https://codereview.chromium.org/1985903003/diff/40001/chrome/test/BUILD.gn#newcode1025 chrome/test/BUILD.gn:1025: sources += [ "../browser/nacl_host/test/nacl_gdb_browsertest.cc" ] It's still here, no?
4 years, 7 months ago (2016-05-17 16:38:15 UTC) #6
Dirk Pranke
lgtm, sorry for the confusion. https://codereview.chromium.org/1985903003/diff/40001/chrome/test/BUILD.gn File chrome/test/BUILD.gn (right): https://codereview.chromium.org/1985903003/diff/40001/chrome/test/BUILD.gn#newcode1025 chrome/test/BUILD.gn:1025: sources += [ "../browser/nacl_host/test/nacl_gdb_browsertest.cc" ...
4 years, 7 months ago (2016-05-17 16:47:22 UTC) #7
Nico
thanks!
4 years, 7 months ago (2016-05-17 16:48:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1985903003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1985903003/40001
4 years, 7 months ago (2016-05-17 16:48:02 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-17 16:51:21 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 16:53:13 UTC) #13
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/ef5de4c4c1074c888f423b1bd31ec9bb714ea8f0
Cr-Commit-Position: refs/heads/master@{#394146}

Powered by Google App Engine
This is Rietveld 408576698