Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issue 1985893002: Fix of Issue 611692 - Chromium autoroller compilation is failing flakily (Closed)

Created:
4 years, 7 months ago by kapishnikov
Modified:
4 years, 7 months ago
Reviewers:
mef, xunjieli
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix of Issue 611692 - Chromium autoroller compilation is failing flakily Renamed 'libcronet' target to 'libcronet_shared' in order to avoid output file name conflict with 'cronet_framework' product_name. BUG=611692 Committed: https://crrev.com/34be3c0ae2e0b5c5d9c204a9a6b2a68d1c9a0334 Cr-Commit-Position: refs/heads/master@{#393967}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M components/cronet.gypi View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kapishnikov
4 years, 7 months ago (2016-05-16 22:20:17 UTC) #2
xunjieli
I don't really know what is the best solution here. rubberstamp LGTM to get the ...
4 years, 7 months ago (2016-05-16 22:22:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1985893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1985893002/1
4 years, 7 months ago (2016-05-16 22:26:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-16 23:03:03 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 23:06:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34be3c0ae2e0b5c5d9c204a9a6b2a68d1c9a0334
Cr-Commit-Position: refs/heads/master@{#393967}

Powered by Google App Engine
This is Rietveld 408576698