Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Unified Diff: blimp/net/browser_connection_handler.h

Issue 1985863002: Incorporate BlobChannel into Blimp image encode/decode pipeline. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blobchannel-helium
Patch Set: nyquist feedback Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/net/browser_connection_handler.h
diff --git a/blimp/net/browser_connection_handler.h b/blimp/net/browser_connection_handler.h
index 2c972c30704e7759b8bea518bda61e7c161d2595..9827139db86d82310fc60e5e5aa958a4440466b9 100644
--- a/blimp/net/browser_connection_handler.h
+++ b/blimp/net/browser_connection_handler.h
@@ -52,9 +52,9 @@ class BLIMP_NET_EXPORT BrowserConnectionHandler
// ConnectionErrorObserver implementation.
void OnConnectionError(int error) override;
- private:
void DropCurrentConnection();
Wez 2016/06/07 01:18:31 This is only valid to call while there is a connec
Kevin M 2016/06/08 00:21:09 See previous comment about idempotent connection d
Wez 2016/06/10 22:29:54 Acknowledged.
+ private:
// Routes incoming messages to the relevant feature-specific handlers.
std::unique_ptr<BlimpMessageDemultiplexer> demultiplexer_;

Powered by Google App Engine
This is Rietveld 408576698