blimp/common/proto/blob_cache.proto - Issue 1985863002: Incorporate BlobChannel into Blimp image encode/decode pipeline.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/common/proto/blob_cache.proto

Issue 1985863002: Incorporate BlobChannel into Blimp image encode/decode pipeline. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blobchannel-helium

Patch Set: nyquist feedback Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/client/session/blimp_client_session.cc ('K') | « blimp/client/session/blimp_client_session.cc ('k') | blimp/engine/BUILD.gn » ('j') | blimp/engine/renderer/engine_image_serialization_processor.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/common/proto/blob_cache.proto

diff --git a/blimp/common/proto/blob_cache.proto b/blimp/common/proto/blob_cache.proto

index 04efd9f6bf81236fe1ba917f2da19405ee2093f1..dbf6a384ba2d0162225377e08ab4ec182613dfd9 100644

--- a/blimp/common/proto/blob_cache.proto

+++ b/blimp/common/proto/blob_cache.proto

@@ -16,6 +16,4 @@ message BlobCacheImageMetadata {

optional bytes id = 1;

optional int32 width = 2;

optional int32 height = 3;

- // TODO(nyquist): Remove |payload| after incorporation of BlobChannel.

- optional bytes payload = 4;

}