blimp/client/feature/compositor/decoding_image_generator.cc - Issue 1985863002: Incorporate BlobChannel into Blimp image encode/decode pipeline.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/feature/compositor/decoding_image_generator.cc

Issue 1985863002: Incorporate BlobChannel into Blimp image encode/decode pipeline. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blobchannel-helium

Patch Set: wez and nyquist feedback Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/client/feature/compositor/blimp_compositor_manager.h ('K') | « blimp/client/feature/compositor/client_image_serialization_processor.cc ('k') | blimp/client/session/blimp_client_session.h » ('j') | blimp/client/session/blimp_client_session.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/feature/compositor/decoding_image_generator.cc

diff --git a/blimp/client/feature/compositor/decoding_image_generator.cc b/blimp/client/feature/compositor/decoding_image_generator.cc

index eaa4f9545be347fd9ceae8858beb48ef608dcc8c..b52a5ae5b921950c90e3b2543d339653e8375e90 100644

--- a/blimp/client/feature/compositor/decoding_image_generator.cc

+++ b/blimp/client/feature/compositor/decoding_image_generator.cc

@@ -6,6 +6,7 @@

#include "base/numerics/safe_conversions.h"

#include "blimp/client/feature/compositor/blimp_image_decoder.h"

+#include "blimp/client/feature/compositor/client_image_serialization_processor.h"

#include "blimp/common/proto/blob_cache.pb.h"

#include "third_party/libwebp/webp/decode.h"

#include "third_party/libwebp/webp/demux.h"

@@ -34,7 +35,10 @@ DecodingImageGenerator::DecodingImageGenerator(const SkImageInfo info,

const void* data,

size_t size)

: SkImageGenerator(info) {

- BlimpImageDecoder(data, size, &decoded_bitmap_);

+ if (!ClientImageSerializationProcessor::GetInstance()->GetAndDecodeBlob(

+ data, size, &decoded_bitmap_)) {

+ DLOG(FATAL) << "GetAndDecodeBlob() failed.";

+ }

}

DecodingImageGenerator::~DecodingImageGenerator() {}