Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3388)

Unified Diff: blimp/net/blob_channel/blob_channel_sender_impl.h

Issue 1985863002: Incorporate BlobChannel into Blimp image encode/decode pipeline. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blobchannel-helium
Patch Set: fix gn dependency warning & rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/net/blob_channel/blob_channel_sender.cc ('k') | blimp/net/blob_channel/blob_channel_sender_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/net/blob_channel/blob_channel_sender_impl.h
diff --git a/blimp/net/blob_channel/blob_channel_sender.h b/blimp/net/blob_channel/blob_channel_sender_impl.h
similarity index 60%
copy from blimp/net/blob_channel/blob_channel_sender.h
copy to blimp/net/blob_channel/blob_channel_sender_impl.h
index 77a3d3e13552d80452998c6c6ad6b16624e1d6b8..a6de8ba68bbb9eaed494e031215f3c391e2e01f3 100644
--- a/blimp/net/blob_channel/blob_channel_sender.h
+++ b/blimp/net/blob_channel/blob_channel_sender_impl.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef BLIMP_NET_BLOB_CHANNEL_BLOB_CHANNEL_SENDER_H_
-#define BLIMP_NET_BLOB_CHANNEL_BLOB_CHANNEL_SENDER_H_
+#ifndef BLIMP_NET_BLOB_CHANNEL_BLOB_CHANNEL_SENDER_IMPL_H_
+#define BLIMP_NET_BLOB_CHANNEL_BLOB_CHANNEL_SENDER_IMPL_H_
#include <memory>
#include <set>
@@ -13,13 +13,14 @@
#include "base/threading/thread_checker.h"
#include "blimp/common/blob_cache/blob_cache.h"
#include "blimp/net/blimp_net_export.h"
+#include "blimp/net/blob_channel/blob_channel_sender.h"
namespace blimp {
// Sends blobs to a remote receiver.
// The transport-specific details are provided by the caller using the Delegate
// subclass.
-class BLIMP_NET_EXPORT BlobChannelSender {
+class BLIMP_NET_EXPORT BlobChannelSenderImpl : public BlobChannelSender {
public:
// Delegate interface for transport-specific implementations of blob transfer
// commands.
@@ -31,18 +32,13 @@ class BLIMP_NET_EXPORT BlobChannelSender {
virtual void DeliverBlob(const BlobId& id, BlobDataPtr data) = 0;
};
- BlobChannelSender(std::unique_ptr<BlobCache> cache,
- std::unique_ptr<Delegate> delegate);
- ~BlobChannelSender();
+ BlobChannelSenderImpl(std::unique_ptr<BlobCache> cache,
+ std::unique_ptr<Delegate> delegate);
+ ~BlobChannelSenderImpl() override;
- // Puts a blob in the local BlobChannel. The blob can then be pushed to the
- // remote receiver via "DeliverBlob()".
- // Does nothing if there is already a blob |id| in the channel.
- void PutBlob(const BlobId& id, BlobDataPtr data);
-
- // Sends the blob |id| to the remote side, if the remote side doesn't already
- // have the blob.
- void DeliverBlob(const BlobId& id);
+ // BlobChannelSender implementation.
+ void PutBlob(const BlobId& id, BlobDataPtr data) override;
+ void DeliverBlob(const BlobId& id) override;
private:
std::unique_ptr<BlobCache> cache_;
@@ -53,9 +49,9 @@ class BLIMP_NET_EXPORT BlobChannelSender {
// delivered, or has been evicted at the receiver.
std::set<BlobId> receiver_cache_contents_;
- DISALLOW_COPY_AND_ASSIGN(BlobChannelSender);
+ DISALLOW_COPY_AND_ASSIGN(BlobChannelSenderImpl);
};
} // namespace blimp
-#endif // BLIMP_NET_BLOB_CHANNEL_BLOB_CHANNEL_SENDER_H_
+#endif // BLIMP_NET_BLOB_CHANNEL_BLOB_CHANNEL_SENDER_IMPL_H_
« no previous file with comments | « blimp/net/blob_channel/blob_channel_sender.cc ('k') | blimp/net/blob_channel/blob_channel_sender_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698