Incorporate BlobChannel into Blimp image encode/decode pipeline.

blimp/client/feature/compositor/blimp_compositor_manager.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BLIMP_CLIENT_FEATURE_COMPOSITOR_BLIMP_COMPOSITOR_MANAGER_H_
 #define BLIMP_CLIENT_FEATURE_COMPOSITOR_BLIMP_COMPOSITOR_MANAGER_H_
 
+#include <map>
+
 #include "base/macros.h"
 #include "blimp/client/feature/compositor/blimp_compositor.h"
 #include "blimp/client/feature/compositor/blimp_gpu_memory_buffer_manager.h"
 #include "blimp/client/feature/render_widget_feature.h"
 #include "cc/trees/layer_tree_settings.h"
 
 namespace blimp {
 namespace client {
 
 class ClientImageSerializationProcessor;
@@ skipping 68 matching lines @@
       const cc::proto::CompositorMessage& message) override;
 
   bool visible_;
 
   gfx::AcceleratedWidget window_;
 
   std::unique_ptr<cc::LayerTreeSettings> settings_;
 
   std::unique_ptr<BlimpGpuMemoryBufferManager> gpu_memory_buffer_manager_;
 
-  // Provides the functionality to deserialize images in SkPicture.
-  std::unique_ptr<ClientImageSerializationProcessor>
-      image_serialization_processor_;
+  // Retrieves and decode images from the BlobChannel.
+  ClientImageSerializationProcessor* image_serialization_processor_;

[nyquist, 2016/06/03 18:30:44]

Nit: Do we want to mention any thing about this being a singleton here, to
clarify the lifetime of the object?

[Kevin M, 2016/06/06 17:43:38]

I'm not sure if that's necessary, given that the variable is bound inside the
module instead of being taken from a caller. IMO lifetime constraints are more
important if they are a part of the public interface, so that the object owner
knows to handle the object lifetimes properly.

If you feel strongly I can still document it, but I'm just explaining my
rationale. :)

[nyquist, 2016/06/06 21:10:46]

Nah, I agree.

 
   // A map of render_widget_ids to the BlimpCompositor instance.
   typedef std::map<int, std::unique_ptr<BlimpCompositor>> CompositorMap;
   CompositorMap compositors_;
 
   // The |active_compositor_| represents the compositor from the CompositorMap
   // that is currently visible and has the |window_|. It corresponds to the
   // render widget currently initialized on the engine.
   BlimpCompositor* active_compositor_;
 
   // Lazily created thread that will run the compositor rendering tasks and will
   // be shared by all compositor instances.
   std::unique_ptr<base::Thread> compositor_thread_;
 
   // The bridge to the network layer that does the proto/RenderWidget id work.
   // BlimpCompositorManager does not own this and it is expected to outlive this
   // BlimpCompositorManager instance.
   RenderWidgetFeature* render_widget_feature_;
   BlimpCompositorManagerClient* client_;
 
   DISALLOW_COPY_AND_ASSIGN(BlimpCompositorManager);
 };
 
 }  // namespace client
 }  // namespace blimp
 
 #endif  // BLIMP_CLIENT_FEATURE_COMPOSITOR_BLIMP_COMPOSITOR_MANAGER_H_