Incorporate BlobChannel into Blimp image encode/decode pipeline.

blimp/engine/mojo/blob_channel_service.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BLIMP_ENGINE_MOJO_BLOB_CHANNEL_SERVICE_H_
 #define BLIMP_ENGINE_MOJO_BLOB_CHANNEL_SERVICE_H_
 
 #include "blimp/engine/mojo/blob_channel.mojom.h"
 #include "mojo/public/cpp/bindings/strong_binding.h"
 
 namespace blimp {
+
+class BlobChannelSender;
+
 namespace engine {
 
 // Service for processing BlobChannel requests from the renderer.
 // Runs on the browser process.
 class BlobChannelService : public mojom::BlobChannel {
  public:
   // Creates a BlobChannel bound to the connection specified by |request|.
-  explicit BlobChannelService(mojom::BlobChannelRequest request);
+  // |blob_channel| must outlive the Mojo connection.
+  explicit BlobChannelService(BlobChannelSender* blob_channel,

[Wez, 2016/05/21 01:08:04]

nit: Drop "explicit" here.

[Kevin M, 2016/05/27 22:35:30]

Done.

+                              mojom::BlobChannelRequest request);
   ~BlobChannelService() override;
 
   // Factory method called by Mojo.

[Wez, 2016/05/21 01:08:04]

Why do we need both the factory method and the constructor to be visible?

[Kevin M, 2016/05/27 22:35:30]

Good question! Done.

-  static void Create(mojo::InterfaceRequest<mojom::BlobChannel> request);
+  static void Create(BlobChannelSender* blob_channel,
+                     mojo::InterfaceRequest<mojom::BlobChannel> request);
 
  private:
   // BlobChannel implementation.
-  void Put(const mojo::String& id, mojo::Array<uint8_t> data) override;
+  void Put(const mojo::String& id, const mojo::String& data) override;
   void Push(const mojo::String& id) override;
 
   // Binds |this| and its object lifetime to a Mojo connection.
   mojo::StrongBinding<mojom::BlobChannel> binding_;
 
+  BlobChannelSender* blob_channel_;

[Wez, 2016/05/21 01:08:04]

nit: Add one-line comment to explain what this is used for.

[Kevin M, 2016/05/27 22:35:30]

Done.

+
   DISALLOW_COPY_AND_ASSIGN(BlobChannelService);
 };
 
 }  // namespace engine
 }  // namespace blimp
 
 #endif  // BLIMP_ENGINE_MOJO_BLOB_CHANNEL_SERVICE_H_