blimp/net/browser_connection_handler.cc - Issue 1985863002: Incorporate BlobChannel into Blimp image encode/decode pipeline.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/net/browser_connection_handler.cc

Issue 1985863002: Incorporate BlobChannel into Blimp image encode/decode pipeline. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blobchannel-helium

Patch Set: moved the blob serialization processor to the compositor manager Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« blimp/client/feature/compositor/blob_image_serialization_processor.cc ('K') | « blimp/net/browser_connection_handler.h ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "blimp/net/browser_connection_handler.h"	5 #include "blimp/net/browser_connection_handler.h"

6	6

7 #include "base/logging.h"	7 #include "base/logging.h"

8 #include "base/macros.h"	8 #include "base/macros.h"

9 #include "blimp/net/blimp_connection.h"	9 #include "blimp/net/blimp_connection.h"

10 #include "blimp/net/blimp_message_checkpointer.h"	10 #include "blimp/net/blimp_message_checkpointer.h"

(...skipping 45 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
56 output_buffer_->SetOutputProcessor(	56 output_buffer_->SetOutputProcessor(

57 connection_->GetOutgoingMessageProcessor());	57 connection_->GetOutgoingMessageProcessor());

58 connection_->AddConnectionErrorObserver(this);	58 connection_->AddConnectionErrorObserver(this);

59 }	59 }

60	60

61 void BrowserConnectionHandler::OnConnectionError(int error) {	61 void BrowserConnectionHandler::OnConnectionError(int error) {

62 DropCurrentConnection();	62 DropCurrentConnection();

63 }	63 }

64	64

65 void BrowserConnectionHandler::DropCurrentConnection() {	65 void BrowserConnectionHandler::DropCurrentConnection() {

66 DCHECK(connection_);

67 output_buffer_->SetOutputProcessor(nullptr);	66 output_buffer_->SetOutputProcessor(nullptr);
	Wez 2016/06/10 22:29:54 nit: You might consider adding an early-return in nit: You might consider adding an early-return in case that \|connection_\| is null, to guard against some later change adding non-idempotent cleanup code. Kevin M 2016/06/10 23:51:50 Done. Show quoted text On 2016/06/10 22:29:54, Wez wrote: > nit: You might consider adding an early-return in case that \|connection_\| is > null, to guard against some later change adding non-idempotent cleanup code. Done.
68 connection_.reset();	67 connection_.reset();

69 }	68 }

70	69

71 } // namespace blimp	70 } // namespace blimp

OLD	NEW