Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: xfa.gyp

Issue 1985843002: Use chromium_code standard for PDFium GYP compilation (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: address comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/third_party.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa.gyp
diff --git a/xfa.gyp b/xfa.gyp
index 32b4b695014aa6d0da6716efeefde1d54824863d..f6293d5774e25f2601ee97e34c54122a4f3f82f7 100644
--- a/xfa.gyp
+++ b/xfa.gyp
@@ -11,14 +11,6 @@
# TODO(thestig): Fix all instances, remove this, pdfium:29
4245, 4310, 4389, 4701, 4702, 4706, 4800,
],
- 'variables': {
- 'clang_warning_flags': [
- # TODO(thestig): Fix all instances, remove this, pdfium:29
- '-Wno-sign-compare',
- ],
- # Make sure Chromium's build/common.gypi doesn't re-add the flag on linux.
- 'cflags_cc!': [ '-Wsign-compare' ],
- },
},
"targets":[
{
« no previous file with comments | « third_party/third_party.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698