Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: third_party/third_party.gyp

Issue 1985843002: Use chromium_code standard for PDFium GYP compilation (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: address comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pdfium.gyp ('k') | xfa.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/third_party.gyp
diff --git a/third_party/third_party.gyp b/third_party/third_party.gyp
index 2e03b5965690598209c1207e73e1116d12cab3ad..41db3b28db10c68d0b8342c663b099ee09763e59 100644
--- a/third_party/third_party.gyp
+++ b/third_party/third_party.gyp
@@ -85,6 +85,13 @@
'freetype/src/base/fttype1.c',
],
}],
+ ['os_posix==1 and clang==0', {
+ 'cflags': [
+ # open_face_PS_from_sfnt_stream() and open_face_from_buffer() in
+ # ftbase.h are unused. GCC needs this flag too.
+ '-Wno-unused-function',
+ ],
+ }],
],
'variables': {
'clang_warning_flags': [
@@ -122,7 +129,7 @@
'conditions': [
['os_posix==1', {
# library contains several enum vs non-enum conditionals.
- 'cflags': [ '-Wno-extra', ],
+ 'cflags': [ '-Wno-extra' ],
}],
],
'variables': {
« no previous file with comments | « pdfium.gyp ('k') | xfa.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698