pdfium.gyp - Issue 1985843002: Use chromium_code standard for PDFium GYP compilation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pdfium.gyp

Issue 1985843002: Use chromium_code standard for PDFium GYP compilation (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: address comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pdfium.gyp

diff --git a/pdfium.gyp b/pdfium.gyp

index 5532bc8360816a25431a757f53933a3d8b7c5e4e..310fec5bf4b0bef922f82c1ef24339317616e360 100644

--- a/pdfium.gyp

+++ b/pdfium.gyp

@@ -4,8 +4,7 @@

{

'variables': {

- # TODO(thakis): Enable this, pdfium:29

- #'chromium_code': 1,

+ 'chromium_code': 1,

'variables': {

'clang_use_pdfium_plugins%': 0,

@@ -95,14 +94,6 @@

'msvs_disabled_warnings': [

4267,

- 'variables': {

- 'clang_warning_flags': [

- # TODO(thestig): Fix all instances, remove this, pdfium:29

- '-Wno-sign-compare',

- ],

- # Make sure Chromium's build/common.gypi doesn't re-add the flag on linux.

- 'cflags_cc!': [ '-Wsign-compare' ],

- },

'targets': [

{

« no previous file with comments | « build_gyp/standalone.gypi ('k') | third_party/third_party.gyp » ('j') | no next file with comments »