Use chromium_code standard for PDFium GYP compilation

third_party/third_party.gyp

Index: third_party/third_party.gyp
diff --git a/third_party/third_party.gyp b/third_party/third_party.gyp
index 2e03b5965690598209c1207e73e1116d12cab3ad..3b3a2572c591cd38accbf96b8b7c3f441538f677 100644
--- a/third_party/third_party.gyp
+++ b/third_party/third_party.gyp
@@ -4,6 +4,7 @@
 
 {
   'variables': {
+    'chromium_code': 0,

[Nico, 2016/05/16 23:47:45]

This defaults to 0, do you need this?

[Wei Li, 2016/05/17 00:23:24]

Done.

     'pdf_enable_xfa%': 0,  # Set to 1 by standalone.gypi in standalone builds.
     'pdf_use_skia%': 0,
   },
@@ -85,6 +86,13 @@
            'freetype/src/base/fttype1.c',
           ],
         }],
+        ['os_posix==1', {
+          'cflags': [
+            # open_face_PS_from_sfnt_stream() and open_face_from_buffer() in
+            # ftbase.h are unused. GCC needs this flag too.

[Nico, 2016/05/16 23:47:45]

Won't it be needed for clang-cl as well? Maybe it should be in clang_warning
flags, and also in an os_posix==1 and clang==0 block

[Wei Li, 2016/05/17 00:23:24]

Yes, clang_warning_flags on line 97 added this flag already. Changed this block
with clang==0.

+            '-Wno-unused-function',
+          ],
+        }],
       ],
       'variables': {
         'clang_warning_flags': [
@@ -122,7 +130,7 @@
       'conditions': [
         ['os_posix==1', {
           # library contains several enum vs non-enum conditionals.
-          'cflags': [ '-Wno-extra', ],
+          'cflags': [ '-Wno-extra' ],
         }],
       ],
       'variables': {