Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: xfa.gyp

Issue 1985843002: Use chromium_code standard for PDFium GYP compilation (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« third_party/third_party.gyp ('K') | « third_party/third_party.gyp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 { 1 {
2 "variables": { 2 "variables": {
3 "pdf_enable_v8%": 1, 3 "pdf_enable_v8%": 1,
4 }, 4 },
5 "target_defaults": { 5 "target_defaults": {
6 "defines": [ 6 "defines": [
7 "PDF_ENABLE_XFA", 7 "PDF_ENABLE_XFA",
8 ], 8 ],
9 'msvs_disabled_warnings': [ 9 'msvs_disabled_warnings': [
10 4005, 4018, 4146, 4333, 4345, 4267, 10 4005, 4018, 4146, 4333, 4345, 4267,
11 # TODO(thestig): Fix all instances, remove this, pdfium:29 11 # TODO(thestig): Fix all instances, remove this, pdfium:29
12 4245, 4310, 4389, 4701, 4702, 4706, 4800, 12 4245, 4310, 4389, 4701, 4702, 4706, 4800,
13 ], 13 ],
14 'variables': {
15 'clang_warning_flags': [
16 # TODO(thestig): Fix all instances, remove this, pdfium:29
17 '-Wno-sign-compare',
18 ],
19 # Make sure Chromium's build/common.gypi doesn't re-add the flag on linux.
20 'cflags_cc!': [ '-Wsign-compare' ],
21 },
22 }, 14 },
23 "targets":[ 15 "targets":[
24 { 16 {
25 "target_name":"xfa", 17 "target_name":"xfa",
26 "type":"static_library", 18 "type":"static_library",
27 'include_dirs': [ 19 'include_dirs': [
28 # This is implicit in GN. 20 # This is implicit in GN.
29 '<(DEPTH)', 21 '<(DEPTH)',
30 '.', 22 '.',
31 'third_party/freetype/include', 23 'third_party/freetype/include',
(...skipping 719 matching lines...) Expand 10 before | Expand all | Expand 10 after
751 "sources": [], 743 "sources": [],
752 }], 744 }],
753 ["OS == 'mac'", { 745 ["OS == 'mac'", {
754 "configurations": {}, 746 "configurations": {},
755 "sources": [], 747 "sources": [],
756 }], 748 }],
757 ] 749 ]
758 } 750 }
759 ] 751 ]
760 } 752 }
OLDNEW
« third_party/third_party.gyp ('K') | « third_party/third_party.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698