Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1985823002: Cleanup various argument and range errors in double.dart and integers.dart. (Closed)

Created:
4 years, 7 months ago by regis
Modified:
4 years, 7 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Cleanup various argument and range errors in double.dart and integers.dart. R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/fcb02325cce8220a776d74a5490a63ccc21ea28a

Patch Set 1 #

Patch Set 2 : RangeError.range takes minValue and maxValue of type int, not num. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -14 lines) Patch
M runtime/lib/double.dart View 1 4 chunks +16 lines, -9 lines 0 comments Download
M runtime/lib/integers.dart View 1 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
regis
4 years, 7 months ago (2016-05-16 20:44:22 UTC) #2
hausner
lgtm
4 years, 7 months ago (2016-05-16 21:23:36 UTC) #3
regis
4 years, 7 months ago (2016-05-16 21:31:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
fcb02325cce8220a776d74a5490a63ccc21ea28a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698