Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(992)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1985813002: Add an intrinsified early out path for Dart timeline calls (Closed)

Created:
4 years, 7 months ago by Cutch
Modified:
4 years, 7 months ago
Reviewers:
zra, rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add an intrinsified early out path for Dart timeline calls BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/84e1fe5cb5e24723a361e0debf96635a94457ce5

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 5

Patch Set 4 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -0 lines) Patch
M runtime/lib/timeline.cc View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download
M runtime/lib/timeline.dart View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 1 2 3 2 chunks +24 lines, -0 lines 1 comment Download
M runtime/vm/intrinsifier_arm64.cc View 1 2 3 2 chunks +24 lines, -0 lines 1 comment Download
M runtime/vm/intrinsifier_ia32.cc View 1 2 3 2 chunks +25 lines, -0 lines 0 comments Download
M runtime/vm/intrinsifier_mips.cc View 1 2 3 2 chunks +23 lines, -0 lines 1 comment Download
M runtime/vm/intrinsifier_x64.cc View 1 2 3 2 chunks +24 lines, -0 lines 0 comments Download
M runtime/vm/method_recognizer.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/thread.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/timeline.h View 1 chunk +3 lines, -0 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/developer_patch.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M sdk/lib/developer/timeline.dart View 1 2 4 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Cutch
4 years, 7 months ago (2016-05-16 20:24:56 UTC) #3
rmacnak
https://codereview.chromium.org/1985813002/diff/40001/runtime/lib/timeline.cc File runtime/lib/timeline.cc (right): https://codereview.chromium.org/1985813002/diff/40001/runtime/lib/timeline.cc#newcode18 runtime/lib/timeline.cc:18: DEFINE_NATIVE_ENTRY(Timline_isDartStreamEnabled, 0) { Timeline https://codereview.chromium.org/1985813002/diff/40001/runtime/lib/timeline.dart File runtime/lib/timeline.dart (right): https://codereview.chromium.org/1985813002/diff/40001/runtime/lib/timeline.dart#newcode7 ...
4 years, 7 months ago (2016-05-16 23:10:52 UTC) #4
Cutch
PTAL https://codereview.chromium.org/1985813002/diff/40001/runtime/lib/timeline.dart File runtime/lib/timeline.dart (right): https://codereview.chromium.org/1985813002/diff/40001/runtime/lib/timeline.dart#newcode7 runtime/lib/timeline.dart:7: patch bool _isDartStreamEnabled() native "Timline_isDartStreamEnabled"; On 2016/05/16 23:10:52, ...
4 years, 7 months ago (2016-05-17 15:47:47 UTC) #5
rmacnak
lgtm
4 years, 7 months ago (2016-05-17 16:39:18 UTC) #6
Cutch
Committed patchset #4 (id:60001) manually as 84e1fe5cb5e24723a361e0debf96635a94457ce5 (presubmit successful).
4 years, 7 months ago (2016-05-17 16:45:34 UTC) #8
zra
4 years, 7 months ago (2016-05-17 17:35:50 UTC) #10
Message was sent while issue was closed. 
dbc

https://codereview.chromium.org/1985813002/diff/60001/runtime/vm/intrinsifier...
File runtime/vm/intrinsifier_arm.cc (right):

https://codereview.chromium.org/1985813002/diff/60001/runtime/vm/intrinsifier...
runtime/vm/intrinsifier_arm.cc:2120: __ cmp(R0, Operand(0));
__ cmp(R0, Operand(0));
__ LoadObject(R0, Bool::True(), NE);
__ LoadObject(R0, Bool::False(), EQ);
__ Ret();

https://codereview.chromium.org/1985813002/diff/60001/runtime/vm/intrinsifier...
File runtime/vm/intrinsifier_arm64.cc (right):

https://codereview.chromium.org/1985813002/diff/60001/runtime/vm/intrinsifier...
runtime/vm/intrinsifier_arm64.cc:2194: __ cmp(R0, Operand(0));
__ cmp(R0, Operand(0));
__ LoadObject(R0, Bool::False());
__ LoadObject(TMP, Bool::True());
__ csel(R0, TMP, R0, NE);

https://codereview.chromium.org/1985813002/diff/60001/runtime/vm/intrinsifier...
File runtime/vm/intrinsifier_mips.cc (right):

https://codereview.chromium.org/1985813002/diff/60001/runtime/vm/intrinsifier...
runtime/vm/intrinsifier_mips.cc:2223: __ lw(V0, Address(V0,
TimelineStream::enabled_offset()));
__ lw(T0, Address(V0, ...));
__ LoadObject(V0, Bool::False());
__ LoadObject(V1, Bool::True());
__ Ret();
__ delay_slot->movz(V0, V1, T0);  // mov if T0 != 0.

Powered by Google App Engine
This is Rietveld 408576698