Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1985763002: Fix ARM build by moving field in Thread (Closed)

Created:
4 years, 7 months ago by Cutch
Modified:
4 years, 7 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix ARM build by moving field in Thread BUG= Committed: https://github.com/dart-lang/sdk/commit/7b42769cd02f5ec4af1fce368a2e12e30706f4c2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/vm/thread.h View 2 chunks +1 line, -1 line 0 comments Download
M runtime/vm/thread.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Cutch
Committed patchset #1 (id:1) manually as 7b42769cd02f5ec4af1fce368a2e12e30706f4c2 (presubmit successful).
4 years, 7 months ago (2016-05-16 17:58:27 UTC) #2
Cutch
TBR
4 years, 7 months ago (2016-05-16 17:58:42 UTC) #5
rmacnak
4 years, 7 months ago (2016-05-16 18:03:46 UTC) #6
Message was sent while issue was closed. 
This also works, but the assert merely wanted an update to the value in
CheckOffsets. We don't care about the value per se, only that arm and simarm
have the same value.

Powered by Google App Engine
This is Rietveld 408576698