Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/cctest/interpreter/bytecode_expectations/ForOf.golden

Issue 1985753002: [interpreter] Introduce fused bytecodes for common sequences. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase onto oth-0058-peephole-fix. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/interpreter/interpreter.cc ('K') | « test/cctest/interpreter/bytecode_expectations/ForIn.golden ('k') | test/cctest/interpreter/bytecode_expectations/FunctionLiterals.golden » ('j') | test/unittests/interpreter/bytecode-peephole-optimizer-unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/interpreter/bytecode_expectations/ForOf.golden
diff --git a/test/cctest/interpreter/bytecode_expectations/ForOf.golden b/test/cctest/interpreter/bytecode_expectations/ForOf.golden
index 6fb1c4b08fe3f73c63097f3cb7cd953231ff183c..bd72e3602cc816ea461b697947d2db09f1dea55c 100644
--- a/test/cctest/interpreter/bytecode_expectations/ForOf.golden
+++ b/test/cctest/interpreter/bytecode_expectations/ForOf.golden
@@ -13,11 +13,10 @@ snippet: "
"
frame size: 16
parameter count: 1
-bytecode array length: 347
+bytecode array length: 343
bytecodes: [
/* 30 E> */ B(StackCheck),
- B(LdaUndefined),
- B(Star), R(4),
+ B(LdrUndefined), R(4),
B(LdaZero),
B(Star), R(3),
B(Mov), R(context), R(11),
@@ -25,14 +24,12 @@ bytecodes: [
/* 48 S> */ B(CreateArrayLiteral), U8(0), U8(0), U8(3),
B(Star), R(14),
/* 48 E> */ B(LdaConstant), U8(1),
- B(KeyedLoadIC), R(14), U8(3),
- B(Star), R(13),
+ B(LdrKeyedProperty), R(14), U8(3), R(13),
/* 48 E> */ B(Call), R(13), R(14), U8(1), U8(1),
/* 48 E> */ B(Star), R(1),
/* 45 S> */ B(Ldar), R(1),
B(Star), R(15),
- B(LoadIC), R(15), U8(2), U8(7),
- B(Star), R(14),
+ B(LdrNamedProperty), R(15), U8(2), U8(7), R(14),
/* 45 E> */ B(Call), R(14), R(15), U8(1), U8(5),
/* 45 E> */ B(Star), R(2),
B(Star), R(13),
@@ -45,21 +42,20 @@ bytecodes: [
B(Ldar), R(2),
B(Star), R(13),
B(LoadIC), R(13), U8(3), U8(9),
- B(JumpIfToBooleanTrue), U8(28),
+ B(JumpIfToBooleanTrue), U8(27),
B(LdaSmi), U8(2),
B(Star), R(3),
B(Ldar), R(2),
B(Star), R(13),
- B(LoadIC), R(13), U8(4), U8(11),
- B(Star), R(0),
+ B(LdrNamedProperty), R(13), U8(4), U8(11), R(0),
B(Ldar), R(4),
/* 34 E> */ B(StackCheck),
B(Ldar), R(0),
B(Star), R(7),
B(LdaZero),
B(Star), R(3),
- B(Jump), U8(-70),
- B(Jump), U8(47),
+ B(Jump), U8(-68),
+ B(Jump), U8(46),
B(Star), R(14),
B(LdaConstant), U8(5),
B(Star), R(13),
@@ -75,8 +71,7 @@ bytecodes: [
B(JumpIfFalse), U8(6),
B(LdaSmi), U8(1),
B(Star), R(3),
- B(LdaContextSlot), R(context), U8(4),
- B(Star), R(13),
+ B(LdrContextSlot), R(context), U8(4), R(13),
B(CallRuntime), U16(Runtime::kReThrow), R(13), U8(1),
B(PopContext), R(8),
B(LdaSmi), U8(-1),
@@ -100,8 +95,8 @@ bytecodes: [
B(JumpIfFalseConstant), U8(9),
B(Ldar), R(1),
B(Star), R(12),
- B(LoadIC), R(12), U8(6), U8(13),
- B(Star), R(5),
+ B(LdrNamedProperty), R(12), U8(6), U8(13), R(5),
+ B(Ldar), R(5),
B(Star), R(12),
B(LdaNull),
B(TestEqual), R(12),
@@ -180,9 +175,9 @@ constant pool: [
kInstanceTypeDontCare,
]
handlers: [
- [10, 152, 158],
- [13, 105, 107],
- [250, 263, 265],
+ [9, 147, 153],
+ [12, 101, 103],
+ [246, 259, 261],
]
---
@@ -192,13 +187,12 @@ snippet: "
"
frame size: 17
parameter count: 1
-bytecode array length: 363
+bytecode array length: 359
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaConstant), U8(0),
/* 42 E> */ B(Star), R(7),
- B(LdaUndefined),
- B(Star), R(4),
+ B(LdrUndefined), R(4),
B(LdaZero),
B(Star), R(3),
B(Mov), R(context), R(12),
@@ -206,14 +200,12 @@ bytecodes: [
/* 68 S> */ B(Ldar), R(7),
B(Star), R(15),
/* 68 E> */ B(LdaConstant), U8(1),
- B(KeyedLoadIC), R(15), U8(3),
- B(Star), R(14),
+ B(LdrKeyedProperty), R(15), U8(3), R(14),
/* 68 E> */ B(Call), R(14), R(15), U8(1), U8(1),
/* 68 E> */ B(Star), R(1),
/* 65 S> */ B(Ldar), R(1),
B(Star), R(16),
- B(LoadIC), R(16), U8(2), U8(7),
- B(Star), R(15),
+ B(LdrNamedProperty), R(16), U8(2), U8(7), R(15),
/* 65 E> */ B(Call), R(15), R(16), U8(1), U8(5),
/* 65 E> */ B(Star), R(2),
B(Star), R(14),
@@ -226,13 +218,12 @@ bytecodes: [
B(Ldar), R(2),
B(Star), R(14),
B(LoadIC), R(14), U8(3), U8(9),
- B(JumpIfToBooleanTrue), U8(32),
+ B(JumpIfToBooleanTrue), U8(31),
B(LdaSmi), U8(2),
B(Star), R(3),
B(Ldar), R(2),
B(Star), R(14),
- B(LoadIC), R(14), U8(4), U8(11),
- B(Star), R(0),
+ B(LdrNamedProperty), R(14), U8(4), U8(11), R(0),
B(Ldar), R(4),
/* 54 E> */ B(StackCheck),
B(Ldar), R(0),
@@ -240,9 +231,9 @@ bytecodes: [
/* 73 S> */ B(Star), R(11),
B(LdaZero),
B(Star), R(10),
- B(Jump), U8(63),
- B(Jump), U8(-74),
- B(Jump), U8(47),
+ B(Jump), U8(62),
+ B(Jump), U8(-72),
+ B(Jump), U8(46),
B(Star), R(15),
B(LdaConstant), U8(5),
B(Star), R(14),
@@ -258,8 +249,7 @@ bytecodes: [
B(JumpIfFalse), U8(6),
B(LdaSmi), U8(1),
B(Star), R(3),
- B(LdaContextSlot), R(context), U8(4),
- B(Star), R(14),
+ B(LdrContextSlot), R(context), U8(4), R(14),
B(CallRuntime), U16(Runtime::kReThrow), R(14), U8(1),
B(PopContext), R(9),
B(LdaSmi), U8(-1),
@@ -283,8 +273,8 @@ bytecodes: [
B(JumpIfFalseConstant), U8(9),
B(Ldar), R(1),
B(Star), R(13),
- B(LoadIC), R(13), U8(6), U8(13),
- B(Star), R(5),
+ B(LdrNamedProperty), R(13), U8(6), U8(13), R(5),
+ B(Ldar), R(5),
rmcilroy 2016/05/24 10:53:56 Interesting situation where we depend on the Ldar
oth 2016/05/24 13:37:12 Yes. It's a funny function too with 2 lines of jav
rmcilroy 2016/05/24 14:00:10 That's ForOf for you ;).
B(Star), R(13),
B(LdaNull),
B(TestEqual), R(13),
@@ -368,9 +358,9 @@ constant pool: [
kInstanceTypeDontCare,
]
handlers: [
- [14, 158, 164],
- [17, 111, 113],
- [257, 270, 272],
+ [13, 153, 159],
+ [16, 107, 109],
+ [253, 266, 268],
]
---
@@ -382,11 +372,10 @@ snippet: "
"
frame size: 16
parameter count: 1
-bytecode array length: 369
+bytecode array length: 365
bytecodes: [
/* 30 E> */ B(StackCheck),
- B(LdaUndefined),
- B(Star), R(4),
+ B(LdrUndefined), R(4),
B(LdaZero),
B(Star), R(3),
B(Mov), R(context), R(11),
@@ -394,14 +383,12 @@ bytecodes: [
/* 48 S> */ B(CreateArrayLiteral), U8(0), U8(0), U8(3),
B(Star), R(14),
/* 48 E> */ B(LdaConstant), U8(1),
- B(KeyedLoadIC), R(14), U8(3),
- B(Star), R(13),
+ B(LdrKeyedProperty), R(14), U8(3), R(13),
/* 48 E> */ B(Call), R(13), R(14), U8(1), U8(1),
/* 48 E> */ B(Star), R(1),
/* 45 S> */ B(Ldar), R(1),
B(Star), R(15),
- B(LoadIC), R(15), U8(2), U8(7),
- B(Star), R(14),
+ B(LdrNamedProperty), R(15), U8(2), U8(7), R(14),
/* 45 E> */ B(Call), R(14), R(15), U8(1), U8(5),
/* 45 E> */ B(Star), R(2),
B(Star), R(13),
@@ -414,13 +401,12 @@ bytecodes: [
B(Ldar), R(2),
B(Star), R(13),
B(LoadIC), R(13), U8(3), U8(9),
- B(JumpIfToBooleanTrue), U8(50),
+ B(JumpIfToBooleanTrue), U8(49),
B(LdaSmi), U8(2),
B(Star), R(3),
B(Ldar), R(2),
B(Star), R(13),
- B(LoadIC), R(13), U8(4), U8(11),
- B(Star), R(0),
+ B(LdrNamedProperty), R(13), U8(4), U8(11), R(0),
B(Ldar), R(4),
/* 34 E> */ B(StackCheck),
B(Ldar), R(0),
@@ -438,8 +424,8 @@ bytecodes: [
/* 104 S> */ B(Jump), U8(7),
B(LdaZero),
B(Star), R(3),
- B(Jump), U8(-92),
- B(Jump), U8(47),
+ B(Jump), U8(-90),
+ B(Jump), U8(46),
B(Star), R(14),
B(LdaConstant), U8(5),
B(Star), R(13),
@@ -455,8 +441,7 @@ bytecodes: [
B(JumpIfFalse), U8(6),
B(LdaSmi), U8(1),
B(Star), R(3),
- B(LdaContextSlot), R(context), U8(4),
- B(Star), R(13),
+ B(LdrContextSlot), R(context), U8(4), R(13),
B(CallRuntime), U16(Runtime::kReThrow), R(13), U8(1),
B(PopContext), R(8),
B(LdaSmi), U8(-1),
@@ -480,8 +465,8 @@ bytecodes: [
B(JumpIfFalseConstant), U8(9),
B(Ldar), R(1),
B(Star), R(12),
- B(LoadIC), R(12), U8(6), U8(13),
- B(Star), R(5),
+ B(LdrNamedProperty), R(12), U8(6), U8(13), R(5),
+ B(Ldar), R(5),
B(Star), R(12),
B(LdaNull),
B(TestEqual), R(12),
@@ -560,9 +545,9 @@ constant pool: [
kInstanceTypeDontCare,
]
handlers: [
- [10, 174, 180],
- [13, 127, 129],
- [272, 285, 287],
+ [9, 169, 175],
+ [12, 123, 125],
+ [268, 281, 283],
]
---
@@ -572,14 +557,13 @@ snippet: "
"
frame size: 15
parameter count: 1
-bytecode array length: 379
+bytecode array length: 375
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(CreateObjectLiteral), U8(0), U8(0), U8(1),
B(Star), R(8),
/* 42 E> */ B(Star), R(6),
- B(LdaUndefined),
- B(Star), R(3),
+ B(LdrUndefined), R(3),
B(LdaZero),
B(Star), R(2),
B(Mov), R(context), R(10),
@@ -587,14 +571,12 @@ bytecodes: [
/* 77 S> */ B(CreateArrayLiteral), U8(1), U8(1), U8(3),
B(Star), R(13),
/* 77 E> */ B(LdaConstant), U8(2),
- B(KeyedLoadIC), R(13), U8(3),
- B(Star), R(12),
+ B(LdrKeyedProperty), R(13), U8(3), R(12),
/* 77 E> */ B(Call), R(12), R(13), U8(1), U8(1),
/* 77 E> */ B(Star), R(0),
/* 74 S> */ B(Ldar), R(0),
B(Star), R(14),
- B(LoadIC), R(14), U8(3), U8(7),
- B(Star), R(13),
+ B(LdrNamedProperty), R(14), U8(3), U8(7), R(13),
/* 74 E> */ B(Call), R(13), R(14), U8(1), U8(5),
/* 74 E> */ B(Star), R(1),
B(Star), R(12),
@@ -607,7 +589,7 @@ bytecodes: [
B(Ldar), R(1),
B(Star), R(12),
B(LoadIC), R(12), U8(4), U8(9),
- B(JumpIfToBooleanTrue), U8(42),
+ B(JumpIfToBooleanTrue), U8(41),
B(LdaSmi), U8(2),
B(Star), R(2),
/* 67 E> */ B(Ldar), R(6),
@@ -620,13 +602,12 @@ bytecodes: [
/* 62 E> */ B(StackCheck),
/* 88 S> */ B(Ldar), R(6),
B(Star), R(12),
- /* 96 E> */ B(LoadIC), R(12), U8(6), U8(15),
- B(Star), R(9),
+ /* 96 E> */ B(LdrNamedProperty), R(12), U8(6), U8(15), R(9),
B(LdaZero),
B(Star), R(8),
- B(Jump), U8(63),
- B(Jump), U8(-84),
- B(Jump), U8(47),
+ B(Jump), U8(62),
+ B(Jump), U8(-82),
+ B(Jump), U8(46),
B(Star), R(13),
B(LdaConstant), U8(7),
B(Star), R(12),
@@ -642,8 +623,7 @@ bytecodes: [
B(JumpIfFalse), U8(6),
B(LdaSmi), U8(1),
B(Star), R(2),
- B(LdaContextSlot), R(context), U8(4),
- B(Star), R(12),
+ B(LdrContextSlot), R(context), U8(4), R(12),
B(CallRuntime), U16(Runtime::kReThrow), R(12), U8(1),
B(PopContext), R(7),
B(LdaSmi), U8(-1),
@@ -667,8 +647,8 @@ bytecodes: [
B(JumpIfFalseConstant), U8(11),
B(Ldar), R(0),
B(Star), R(11),
- B(LoadIC), R(11), U8(8), U8(17),
- B(Star), R(4),
+ B(LdrNamedProperty), R(11), U8(8), U8(17), R(4),
+ B(Ldar), R(4),
B(Star), R(11),
B(LdaNull),
B(TestEqual), R(11),
@@ -754,8 +734,8 @@ constant pool: [
kInstanceTypeDontCare,
]
handlers: [
- [18, 174, 180],
- [21, 127, 129],
- [273, 286, 288],
+ [17, 169, 175],
+ [20, 123, 125],
+ [269, 282, 284],
]
« src/interpreter/interpreter.cc ('K') | « test/cctest/interpreter/bytecode_expectations/ForIn.golden ('k') | test/cctest/interpreter/bytecode_expectations/FunctionLiterals.golden » ('j') | test/unittests/interpreter/bytecode-peephole-optimizer-unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698