Always check if providers have initial stability metrics.

components/metrics/metrics_service_unittest.cc

Index: components/metrics/metrics_service_unittest.cc
diff --git a/components/metrics/metrics_service_unittest.cc b/components/metrics/metrics_service_unittest.cc
index a19e27b83a8f47b704fb973c68361f7df10893df..da4894af219f5152d31a7f49264ddeb31696bbc7 100644
--- a/components/metrics/metrics_service_unittest.cc
+++ b/components/metrics/metrics_service_unittest.cc
@@ -176,6 +176,8 @@ TEST_F(MetricsServiceTest, InitialStabilityLogAfterCleanShutDown) {
       std::unique_ptr<MetricsProvider>(test_provider));
 
   service.InitializeMetricsRecordingState();
+  EXPECT_TRUE(test_provider->has_initial_stability_metrics_called());

[Alexei Svitkine (slow), 2016/05/16 17:02:31]

Move this to the end of the function and add a comment about it, similar to
what's on line 185 - explaining *why* this behavior is desired, like you do in
the CL description.

[bcwhite, 2016/05/16 17:30:49]

Done.  Though I put it before the other test_provider call-tests so the order of
the tests continues to matche the order in which methods would be called.

+
   // No initial stability log should be generated.
   EXPECT_FALSE(service.log_manager()->has_unsent_logs());
   EXPECT_FALSE(service.log_manager()->has_staged_log());
@@ -216,6 +218,7 @@ TEST_F(MetricsServiceTest, InitialStabilityLogAtProviderRequest) {
       std::unique_ptr<MetricsProvider>(test_provider));
 
   service.InitializeMetricsRecordingState();
+  EXPECT_TRUE(test_provider->has_initial_stability_metrics_called());
 
   // The initial stability log should be generated and persisted in unsent logs.
   MetricsLogManager* log_manager = service.log_manager();
@@ -280,6 +283,7 @@ TEST_F(MetricsServiceTest, InitialStabilityLogAfterCrash) {
   service.RegisterMetricsProvider(
       std::unique_ptr<MetricsProvider>(test_provider));
   service.InitializeMetricsRecordingState();
+  EXPECT_TRUE(test_provider->has_initial_stability_metrics_called());
 
   // The initial stability log should be generated and persisted in unsent logs.
   MetricsLogManager* log_manager = service.log_manager();