third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp - Issue 1985703003: Add isUnique check to isSameSchemeHostPort.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp

Issue 1985703003: Add isUnique check to isSameSchemeHostPort. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: separate out == check, and add some tests Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp

diff --git a/third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp b/third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp

index 84f740fc03ff7327967632e6f58fb297406c20b3..395869e19890b922b492fccd45a8b071aeafcb1d 100644

--- a/third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp

+++ b/third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp

@@ -531,6 +531,12 @@ PassRefPtr<SecurityOrigin> SecurityOrigin::create(const String& protocol, const

bool SecurityOrigin::isSameSchemeHostPort(const SecurityOrigin* other) const

{

+ if (this == other)

+ return true;

+ if (isUnique() || other->isUnique())

+ return false;

if (m_host != other->m_host)

return false;