Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1226)

Unified Diff: third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp

Issue 1985703003: Add isUnique check to isSameSchemeHostPort. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: change check rather than comment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp
diff --git a/third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp b/third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp
index e7012fddde34d3dcb282ed483bf29ac35a3bc28d..6d9372ba2fd1ffa4d5faf1933efd9e4748877955 100644
--- a/third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp
+++ b/third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp
@@ -531,6 +531,9 @@ PassRefPtr<SecurityOrigin> SecurityOrigin::create(const String& protocol, const
bool SecurityOrigin::isSameSchemeHostPort(const SecurityOrigin* other) const
{
+ if (this != other && (isUnique() || other->isUnique()))
jww 2016/06/02 20:49:56 IMO, if would simpler to first have a check: if
Marijn Kruisselbrink 2016/06/02 21:18:53 Done. Assuming that that was indeed a bug in the i
+ return false;
+
if (m_host != other->m_host)
return false;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698