Chromium Code Reviews| Index: tools/perf/measurements/loading_measurement_analyzer.py |
| diff --git a/tools/perf/measurements/loading_measurement_analyzer.py b/tools/perf/measurements/loading_measurement_analyzer.py |
| index eae217381705e8d012dabc3d79b1f31cfc3dde75..a5abe11ac685340ccca200c0a57dfb381d34a46b 100755 |
| --- a/tools/perf/measurements/loading_measurement_analyzer.py |
| +++ b/tools/perf/measurements/loading_measurement_analyzer.py |
| @@ -9,7 +9,7 @@ Example usage: |
| $ tools/perf/run_measurement --browser=release \ |
| --output-format=csv --output=/path/to/loading_measurement_output.csv \ |
| loading_measurement tools/perf/page_sets/top_1m.json |
| -$ tools/perf/perf_tools/loading_measurement_analyzer.py \ |
| +$ tools/perf/measurements/loading_measurement_analyzer.py \ |
| --num-slowest-urls=100 --rank-csv-file=/path/to/top-1m.csv \ |
| /path/to/loading_measurement_output.csv |
| """ |
| @@ -45,7 +45,7 @@ class LoadingMeasurementAnalyzer(object): |
| for key, value in row.iteritems(): |
| if key in ('url', 'dom_content_loaded_time (ms)', 'load_time (ms)'): |
| continue |
| - if not value: |
| + if not value or value == '-': |
|
nduca
2013/07/23 06:01:27
i think this script is starting to get to the poin
tonyg
2013/07/23 18:41:21
You are probably right. Would you mind terribly if
|
| continue |
| if '_avg' in key: |
| self.avgs[key].append((float(value), row['url'])) |
| @@ -89,7 +89,8 @@ class LoadingMeasurementAnalyzer(object): |
| if not self.num_slowest_urls: |
| return |
| - for key, values in self.totals.iteritems(): |
| + for key, values in sorted(self.totals.iteritems(), reverse=True, |
| + key=lambda i: sum_totals[i[0]]): |
| print 'Top %d slowest %s:' % (self.num_slowest_urls, |
| key.replace(' (ms)', '')) |