Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1985673002:
[Interpreter] Removes failure expectation for gc related blink_tests. (Closed)
Description[Interpreter] Removes failure expectation for gc related blink_tests.
Updates blink_tests/TestExpecations by removing failure expectation for
gc related tests. These tests are modified to work with ignition by
the following cls:
https://codereview.chromium.org/1972943002/
https://codereview.chromium.org/1950613005/
BUG=v8:4280, chromium:595672
LOG=N
Committed: https://crrev.com/b498f0c93b3cf231f1f1507dd0a4c513a3fc15a6
Cr-Commit-Position: refs/heads/master@{#36326}
Patch Set 1 #Patch Set 2 : Rebased the patch. #Messages
Total messages: 18 (8 generated)
mythria@chromium.org changed reviewers: + rmcilroy@chromium.org
PTAL.
Awesome, LGTM thanks.
The CQ bit was checked by mythria@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1985673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1985673002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...) v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...) v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/5843) v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...) v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...) v8_linux_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/5833) v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/15359) v8_win64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/7381)
The CQ bit was checked by mythria@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1985673002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1985673002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mythria@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rmcilroy@chromium.org Link to the patchset: https://codereview.chromium.org/1985673002/#ps20001 (title: "Rebased the patch.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1985673002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1985673002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Removes failure expectation for gc related blink_tests. Updates blink_tests/TestExpecations by removing failure expectation for gc related tests. These tests are modified to work with ignition by the following cls: https://codereview.chromium.org/1972943002/ https://codereview.chromium.org/1950613005/ BUG=v8:4280,chromium:595672 LOG=N ========== to ========== [Interpreter] Removes failure expectation for gc related blink_tests. Updates blink_tests/TestExpecations by removing failure expectation for gc related tests. These tests are modified to work with ignition by the following cls: https://codereview.chromium.org/1972943002/ https://codereview.chromium.org/1950613005/ BUG=v8:4280,chromium:595672 LOG=N Committed: https://crrev.com/b498f0c93b3cf231f1f1507dd0a4c513a3fc15a6 Cr-Commit-Position: refs/heads/master@{#36326} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b498f0c93b3cf231f1f1507dd0a4c513a3fc15a6 Cr-Commit-Position: refs/heads/master@{#36326}
Message was sent while issue was closed.
FYI: A bunch of tests are failing: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064%20-... |
