Don't let PDBSourceLineWriter::GetSymbolFunctionName return empty function names

Don't let PDBSourceLineWriter::GetSymbolFunctionName return empty function names

It's possible for `IDiaSymbol::get_name` to return S_OK and provide
and empty string. I haven't figured out the exact root cause yet
(the symbols in question are coming from the Rust standard library),
but FUNC lines with missing function names break the processor and
so we should never do it. This change makes it output "<name omitted>"
which matches the behavior of the DWARF dumping code.

R=mark@chromium.org
BUG=https://bugzilla.mozilla.org/show_bug.cgi?id=1272278

Committed: https://chromium.googlesource.com/breakpad/breakpad/+/67d5567177301d0c24303f26ad119ab7bd7fab40

[Mark Mentovai, 2016-05-16 16:27:17]

LGTM

[Ted Mielczarek, 2016-05-16 16:31:02]

Description was changed from

==========
Don't let PDBSourceLineWriter::GetSymbolFunctionName return empty function names

It's possible for `IDiaSymbol::get_name` to return S_OK and provide
and empty string. I haven't figured out the exact root cause yet
(the symbols in question are coming from the Rust standard library),
but FUNC lines with missing function names break the processor and
so we should never do it. This change makes it output "<name omitted>"
which matches the behavior of the DWARF dumping code.

R=mark@chromium.org
BUG=https://bugzilla.mozilla.org/show_bug.cgi?id=1272278
==========

to

==========
Don't let PDBSourceLineWriter::GetSymbolFunctionName return empty function names

It's possible for `IDiaSymbol::get_name` to return S_OK and provide
and empty string. I haven't figured out the exact root cause yet
(the symbols in question are coming from the Rust standard library),
but FUNC lines with missing function names break the processor and
so we should never do it. This change makes it output "<name omitted>"
which matches the behavior of the DWARF dumping code.

R=mark@chromium.org
BUG=https://bugzilla.mozilla.org/show_bug.cgi?id=1272278

Committed:
https://chromium.googlesource.com/breakpad/breakpad/+/67d5567177301d0c24303f2...
==========

[Ted Mielczarek, 2016-05-16 16:31:05]

Committed patchset #1 (id:1) manually as
67d5567177301d0c24303f26ad119ab7bd7fab40 (presubmit successful).