Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Issue 1985643003: Revert of Simplify LoadableTextTrack::trackElementIndex (Closed)

Created:
4 years, 7 months ago by fs
Modified:
4 years, 7 months ago
Reviewers:
davve
CC:
fs, blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, gasubic, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Simplify LoadableTextTrack::trackElementIndex (patchset #1 id:1 of https://codereview.chromium.org/1980013002/ ) Reason for revert: Seems "WebKit Win Builder (dbg)" didn't approve: e:\b\build\slave\webkit-win-latest-dbg\build\src\third_party\webkit\source\core\html\track\loadabletexttrack.cpp(70) : warning C4706: assignment within conditional expression Original issue's description: > Simplify LoadableTextTrack::trackElementIndex > > Count preceding sibling <track> elements in a more straight-forward way. > > Also clean-up null-checks of m_trackElement while here (should be non- > null on construction and then keeps a strong reference.) > > Committed: https://crrev.com/0537a6d11bf2ebefcf90fbfec7081e37ef78081a > Cr-Commit-Position: refs/heads/master@{#393825} TBR=davve@opera.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/58d9174b50bc167b9ae9212d7ec7f3d0cda625c7 Cr-Commit-Position: refs/heads/master@{#393828}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M third_party/WebKit/Source/core/html/track/LoadableTextTrack.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/LoadableTextTrack.cpp View 3 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
fs
Created Revert of Simplify LoadableTextTrack::trackElementIndex
4 years, 7 months ago (2016-05-16 13:50:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1985643003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1985643003/1
4 years, 7 months ago (2016-05-16 13:50:47 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-16 13:51:21 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 13:52:21 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/58d9174b50bc167b9ae9212d7ec7f3d0cda625c7
Cr-Commit-Position: refs/heads/master@{#393828}

Powered by Google App Engine
This is Rietveld 408576698