Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 1985623003: [system-health] Remove engadget.com from system_health.memory_{mobile,desktop} benchmarks (Closed)

Created:
4 years, 7 months ago by petrcermak
Modified:
4 years, 7 months ago
Reviewers:
nednguyen, sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[system-health] Remove engadget.com from system_health.memory_{mobile,desktop} benchmarks Rationale: The story sometimes times out on desktop. Since the website doesn't rank among the most popular pages (438 global rank, 291 USA rank according to http://www.alexa.com/siteinfo/engadget.com), it's fine to just remove it from the benchmarks completely. BUG=612135, 589726 Committed: https://crrev.com/69f0c52f297c33898ed73c35337e2ab1c345d0f0 Cr-Commit-Position: refs/heads/master@{#393831}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M tools/perf/page_sets/data/memory_system_health_desktop.json View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/data/memory_system_health_mobile.json View 1 chunk +1 line, -2 lines 0 comments Download
M tools/perf/page_sets/system_health_stories.py View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
petrcermak
PTAL. Thanks, Petr
4 years, 7 months ago (2016-05-16 13:21:18 UTC) #3
sullivan
lgtm
4 years, 7 months ago (2016-05-16 13:36:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1985623003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1985623003/1
4 years, 7 months ago (2016-05-16 13:47:46 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-16 14:58:02 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 14:59:14 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/69f0c52f297c33898ed73c35337e2ab1c345d0f0
Cr-Commit-Position: refs/heads/master@{#393831}

Powered by Google App Engine
This is Rietveld 408576698