third_party/WebKit/Source/bindings/core/v8/Microtask.h - Issue 1985623002: [WIP] Custom element upgrades

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/Microtask.h

Issue 1985623002: [WIP] Custom element upgrades (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a C++-only test.' Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/Microtask.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/Microtask.h b/third_party/WebKit/Source/bindings/core/v8/Microtask.h

index 2a686dc850660a43e14f88a6fba8ac944e738f38..666d3f0972178590638ffd8d8a65b03b8a516b38 100644

--- a/third_party/WebKit/Source/bindings/core/v8/Microtask.h

+++ b/third_party/WebKit/Source/bindings/core/v8/Microtask.h

@@ -52,7 +52,7 @@ namespace blink {

// Calls of type (1) should generally go through ScriptController, as inspector

// instrumentation is needed. ScriptController allocates V8RecursionScope for you.

-// Calls of type (2) should always stack-allocate a v8::MicrotasksScope(kRunMicrtoasks)

+// Calls of type (2) should always stack-allocate a v8::MicrotasksScope(kRunMicrotasks)

// in the same block as the call into script.

// Calls of type (3) should stack allocate a v8::MicrotasksScope(kDoNotRunMicrotasks) --