Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 198553002: Use new is*Element() helper functions even more in HTML code (Closed)

Created:
6 years, 9 months ago by Inactive
Modified:
6 years, 9 months ago
Reviewers:
adamk, eseidel
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Visibility:
Public.

Description

Use new is*Element() helper functions even more in HTML code Use new is*Element() helpers even more in HTML code. This makes the code clearer and simpler. Also use the new Traversal<*Element> API when suitable. R=eseidel, adamk BUG=346095 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169166

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -72 lines) Patch
M Source/core/html/FormAssociatedElement.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/html/HTMLAnchorElement.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/html/HTMLAreaElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLDetailsElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLDialogElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLElement.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/html/HTMLEmbedElement.cpp View 3 chunks +6 lines, -5 lines 0 comments Download
M Source/core/html/HTMLFieldSetElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFormControlElement.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLFormControlsCollection.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 6 chunks +24 lines, -26 lines 0 comments Download
M Source/core/html/HTMLFrameElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFrameSetElement.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/html/HTMLImageLoader.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
6 years, 9 months ago (2014-03-13 03:41:52 UTC) #1
adamk
lgtm
6 years, 9 months ago (2014-03-13 20:10:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/198553002/1
6 years, 9 months ago (2014-03-13 20:10:22 UTC) #3
commit-bot: I haz the power
6 years, 9 months ago (2014-03-13 22:20:42 UTC) #4
Message was sent while issue was closed.
Change committed as 169166

Powered by Google App Engine
This is Rietveld 408576698