Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1985473002: Simplify HeapVectorBacking<> usage. (Closed)

Created:
4 years, 7 months ago by sof
Modified:
4 years, 7 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify HeapVectorBacking<> usage. Reorder HeapAllocator.h declarations to let the compiler handle supplying the default trait argument to HeapVectorBacking<>. R= BUG= Committed: https://crrev.com/75cc3d2bfcfa07fb237ae04773496b31bbb59e15 Cr-Commit-Position: refs/heads/master@{#393749}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -20 lines) Patch
M third_party/WebKit/Source/platform/heap/HeapAllocator.h View 6 chunks +18 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look.
4 years, 7 months ago (2016-05-14 06:32:19 UTC) #2
haraken
LGTM
4 years, 7 months ago (2016-05-14 07:24:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1985473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1985473002/1
4 years, 7 months ago (2016-05-14 07:56:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-14 20:34:55 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-14 20:36:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/75cc3d2bfcfa07fb237ae04773496b31bbb59e15
Cr-Commit-Position: refs/heads/master@{#393749}

Powered by Google App Engine
This is Rietveld 408576698