Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 1985393002: WTF: Add support for std::initializer_list in Vector. (Closed)

Created:
4 years, 7 months ago by Yuta Kitamura
Modified:
4 years, 7 months ago
Reviewers:
*tzik
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WTF: Add support for std::initializer_list in Vector. BUG=610931 Committed: https://crrev.com/33dd1a29f89535b139dad237369b82deb4154e30 Cr-Commit-Position: refs/heads/master@{#394363}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add tests for different ways of construction. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -0 lines) Patch
M third_party/WebKit/Source/wtf/Vector.h View 3 chunks +32 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/VectorTest.cpp View 1 1 chunk +74 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1985393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1985393002/1
4 years, 7 months ago (2016-05-18 03:37:54 UTC) #2
Yuta Kitamura
PTAL?
4 years, 7 months ago (2016-05-18 03:42:49 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/192145)
4 years, 7 months ago (2016-05-18 04:59:43 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1985393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1985393002/1
4 years, 7 months ago (2016-05-18 05:30:46 UTC) #9
tzik
lgtm https://codereview.chromium.org/1985393002/diff/1/third_party/WebKit/Source/wtf/VectorTest.cpp File third_party/WebKit/Source/wtf/VectorTest.cpp (right): https://codereview.chromium.org/1985393002/diff/1/third_party/WebKit/Source/wtf/VectorTest.cpp#newcode675 third_party/WebKit/Source/wtf/VectorTest.cpp:675: EXPECT_EQ(3, vector3[2]); Could you add cases for an ...
4 years, 7 months ago (2016-05-18 05:52:55 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/192193)
4 years, 7 months ago (2016-05-18 06:29:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1985393002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1985393002/20001
4 years, 7 months ago (2016-05-18 06:55:01 UTC) #15
Yuta Kitamura
Thanks! https://codereview.chromium.org/1985393002/diff/1/third_party/WebKit/Source/wtf/VectorTest.cpp File third_party/WebKit/Source/wtf/VectorTest.cpp (right): https://codereview.chromium.org/1985393002/diff/1/third_party/WebKit/Source/wtf/VectorTest.cpp#newcode675 third_party/WebKit/Source/wtf/VectorTest.cpp:675: EXPECT_EQ(3, vector3[2]); On 2016/05/18 05:52:55, tzik wrote: > ...
4 years, 7 months ago (2016-05-18 06:55:23 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-18 08:41:18 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 08:42:49 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/33dd1a29f89535b139dad237369b82deb4154e30
Cr-Commit-Position: refs/heads/master@{#394363}

Powered by Google App Engine
This is Rietveld 408576698