Logging and check fail crbug/612358

storage/browser/blob/blob_reader.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "storage/browser/blob/blob_reader.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 66 matching lines @@
 
 BlobReader::~BlobReader() {
   STLDeleteValues(&index_to_reader_);
 }
 
 BlobReader::Status BlobReader::CalculateSize(
     const net::CompletionCallback& done) {
   DCHECK(!total_size_calculated_);
   DCHECK(size_callback_.is_null());
   if (!blob_handle_.get() || blob_handle_->IsBroken()) {
+    LOG(ERROR) << "Broken blob, or non existant";
     return ReportError(net::ERR_FILE_NOT_FOUND);
   }
   if (blob_handle_->IsBeingBuilt()) {
+    LOG(ERROR) << blob_handle_->uuid() << " blob still being built";
     blob_handle_->RunOnConstructionComplete(base::Bind(
         &BlobReader::AsyncCalculateSize, weak_factory_.GetWeakPtr(), done));
     return Status::IO_PENDING;
   }
   blob_data_ = blob_handle_->CreateSnapshot();
   return CalculateSizeImpl(done);
 }
 
 bool BlobReader::has_side_data() const {
   if (!blob_data_.get())
@@ skipping 141 matching lines @@
                                             net::CompletionCallback done) {
   net_error_ = net_error;
   weak_factory_.InvalidateWeakPtrs();
   size_callback_.Reset();
   read_callback_.Reset();
   read_buf_ = nullptr;
   done.Run(net_error);
 }
 
 BlobReader::Status BlobReader::ReportError(int net_error) {
+  LOG(ERROR) << "Reporting error << " << net_error;
   net_error_ = net_error;
   return Status::NET_ERROR;
 }
 
 void BlobReader::AsyncCalculateSize(const net::CompletionCallback& done,
                                     bool async_succeeded,
                                     IPCBlobCreationCancelCode reason) {
   if (!async_succeeded) {
+    LOG(ERROR) << "Blob construction failed";
     InvalidateCallbacksAndDone(ConvertBlobErrorToNetError(reason), done);
     return;
   }
+  LOG(ERROR) << blob_handle_->uuid() << " consruction done";
   DCHECK(!blob_handle_->IsBroken()) << "Callback should have returned false.";
   blob_data_ = blob_handle_->CreateSnapshot();
   Status size_status = CalculateSizeImpl(done);
   switch (size_status) {
     case Status::NET_ERROR:
       InvalidateCallbacksAndDone(net_error_, done);
       return;
     case Status::DONE:
       done.Run(net::OK);
       return;
@@ skipping 396 matching lines @@
       index_to_reader_.erase(found);
       return;
     }
     found->second = reader.release();
   } else if (reader.get()) {
     index_to_reader_[current_item_index_] = reader.release();
   }
 }
 
 }  // namespace storage