Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1240)

Unified Diff: test/mjsunit/compiler/math-constants.js

Issue 198533007: Inline mathematical constants (Closed) Base URL: https://github.com/v8/v8.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/compiler/math-constants.js
diff --git a/test/mjsunit/compiler/math-constants.js b/test/mjsunit/compiler/math-constants.js
new file mode 100644
index 0000000000000000000000000000000000000000..0d598e30a96873fcef484eea0a0c7aa936b84277
--- /dev/null
+++ b/test/mjsunit/compiler/math-constants.js
@@ -0,0 +1,113 @@
+// Copyright 2014 the V8 project authors. All rights reserved.
+// Redistribution and use in source and binary forms, with or without
+// modification, are permitted provided that the following conditions are
+// met:
+//
+// * Redistributions of source code must retain the above copyright
+// notice, this list of conditions and the following disclaimer.
+// * Redistributions in binary form must reproduce the above
+// copyright notice, this list of conditions and the following
+// disclaimer in the documentation and/or other materials provided
+// with the distribution.
+// * Neither the name of Google Inc. nor the names of its
+// contributors may be used to endorse or promote products derived
+// from this software without specific prior written permission.
+//
+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+// Flags: --allow-natives-syntax --noalways-opt
+
+var globalObject = new Function("return this")();
+//Cache the original Math object for re-optimizations
+var mathObject = Math;
+var NOT_OPTIMIZED = 2;
+var OPTIMIZED = 1;
+
+function getPi() {
+ return Math.PI;
+}
+
+function optimizeGetPi() {
+ assertUnoptimized(getPi);
+ var pi = getPi();
+ getPi();
+ %OptimizeFunctionOnNextCall(getPi);
+ getPi();
+ assertOptimized(getPi);
+ //Optimized result must always be equal to the unoptimized result
+ assertEquals(pi, getPi());
+}
+
+
+optimizeGetPi();
+assertOptimized(getPi);
+//normal assignment should deoptimize
+Math = {PI: 1.24};
+assertUnoptimized(getPi);
+assertEquals(getPi(), 1.24);
+Math = mathObject;
+
+
+optimizeGetPi();
+assertOptimized(getPi);
+//delete should deoptimize
+delete Math;
+assertUnoptimized(getPi);
+try {
+ getPi();
+ assertTrue(false);
+}
+catch(e) {
+ assertTrue(true);
+}
+Math = mathObject;
+
+
+optimizeGetPi();
+assertOptimized(getPi);
+//defining accessor descriptor should deoptimize
+Object.defineProperty(globalObject, "Math", {
+ get: function() {
+ return {PI: 1.24};
+ },
+ set: function(value) {
+ Object.defineProperty(globalObject, "Math", {
+ value: value,
+ enumerable: true,
+ writable: true,
+ configurable: true
+ });
+ },
+ configurable: true,
+ enumerable: true
+});
+assertUnoptimized(getPi);
+assertEquals(getPi(), 1.24);
+Math = mathObject;
+
+optimizeGetPi();
+assertOptimized(getPi);
+//defining data descriptor should deoptimize
+Object.defineProperty(globalObject, "Math", {
+ value: {PI: 1.24},
+ configurable: true,
+ enumerable: true,
+ writable: true
+});
+assertUnoptimized(getPi);
+assertEquals(getPi(), 1.24);
+Math = mathObject;
+
+
+optimizeGetPi();
+assertOptimized(getPi);
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698